Steps: 1. Add a property by "foo" 2. Press Enter 3. Type value name "bar" 4. Press Enter Expected: Property "foo: bar;" has a red strike-through. Actual: Property "foo: bar;" doesn't have a red strike-through. Updating the rule by toggling some other properties makes it show the red strike-through as expected.
Created attachment 324175 [details] [Animated GIF] Bug
<rdar://problem/35062131>
Created attachment 324620 [details] Patch
Created attachment 324621 [details] [Animated GIF] With patch applied HTML page for manual testing: http://nv.github.io/webkit-inspector-bugs/styles-redesign/tests/invalid.html
Comment on attachment 324620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324620&action=review r=me > Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:367 > + let index = insertAfterIndex + 1; Nit: propertyIndex > Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:371 > + const dontFireEvents = true; Nit: suppressEvents or suppressEventDispatch > Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:-128 > - this._element.classList.add(...classNames); I'd keep this as-is, unless there is some reason not to.
Comment on attachment 324620 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324620&action=review >> Source/WebInspectorUI/UserInterface/Views/SpreadsheetStyleProperty.js:-128 >> - this._element.classList.add(...classNames); > > I'd keep this as-is, unless there is some reason not to. It used to be: this.element.className = ""; ... this._element.classList.add(...classNames); I replaced it with this._element.className = classNames.join(" "); to make it more concise.
Created attachment 324856 [details] Patch
Comment on attachment 324856 [details] Patch Clearing flags on attachment: 324856 Committed r223970: <https://trac.webkit.org/changeset/223970>
All reviewed patches have been landed. Closing bug.