Bug 178486 - TestController should clear all fetch caches when resetting its state
Summary: TestController should clear all fetch caches when resetting its state
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-18 15:00 PDT by youenn fablet
Modified: 2017-10-18 19:16 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.44 KB, patch)
2017-10-18 15:01 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.57 KB, patch)
2017-10-18 16:03 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (2.62 KB, patch)
2017-10-18 16:22 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (7.70 KB, patch)
2017-10-18 17:15 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-10-18 15:00:44 PDT 
TestController should clear all fetch caches when resetting its state
Comment 1 youenn fablet 2017-10-18 15:01:59 PDT 
Created attachment 324171 [details]
Patch
Comment 2 Chris Dumez 2017-10-18 15:26:16 PDT 
Comment on attachment 324171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324171&action=review

> Tools/WebKitTestRunner/TestController.cpp:787
> +    clearDOMCache(emptyString.get());

Wouldn't it be nicer to use separate methods rather than a magic value?
clearDOMCacheForOrigin(origin);
clearDOMCache();
Comment 3 youenn fablet 2017-10-18 16:03:40 PDT 
Created attachment 324179 [details]
Patch
Comment 4 youenn fablet 2017-10-18 16:22:52 PDT 
Created attachment 324180 [details]
Patch
Comment 5 Chris Dumez 2017-10-18 16:33:40 PDT 
Comment on attachment 324180 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324180&action=review

> Tools/WebKitTestRunner/TestController.cpp:2338
> +void TestController::clearDOMCaches()

You kept the magic value handing is clearDOMCache(WKStringRef origin).
Comment 6 youenn fablet 2017-10-18 17:15:58 PDT 
Created attachment 324183 [details]
Patch
Comment 7 WebKit Commit Bot 2017-10-18 19:14:58 PDT 
Comment on attachment 324183 [details]
Patch

Clearing flags on attachment: 324183

Committed r223648: <https://trac.webkit.org/changeset/223648>
Comment 8 WebKit Commit Bot 2017-10-18 19:15:00 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-10-18 19:16:15 PDT 
<rdar://problem/35066305>