RESOLVED FIXED 178479
[FrameView::layout cleanup] Use SetForScope to protect m_needsFullRepaint's value on reentrancy 
https://bugs.webkit.org/show_bug.cgi?id=178479
Summary [FrameView::layout cleanup] Use SetForScope to protect m_needsFullRepaint's v...
zalan
Reported 2017-10-18 11:49:14 PDT
ssia.
Attachments
Patch (2.51 KB, patch)
2017-10-18 11:52 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (2.23 KB, patch)
2017-10-18 13:00 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-18 11:49:39 PDT
<rdar://problem/35056950>
zalan
Comment 2 2017-10-18 11:52:41 PDT
Created attachment 324144 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-10-18 12:55:26 PDT
Comment on attachment 324144 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324144&action=review > Source/WebCore/page/FrameView.cpp:1527 > + SetForScope<bool> needsFullRepaint(m_needsFullRepaint); > + if (!isSubtreeLayout && !downcast<RenderView>(*layoutRoot).printing()) { Can't you just move the scope inside the if () condition, rather than adding an extra set of braces?
zalan
Comment 4 2017-10-18 13:00:05 PDT
Created attachment 324155 [details] Patch
WebKit Commit Bot
Comment 5 2017-10-18 15:27:59 PDT
Comment on attachment 324155 [details] Patch Clearing flags on attachment: 324155 Committed r223633: <https://trac.webkit.org/changeset/223633>
WebKit Commit Bot
Comment 6 2017-10-18 15:28:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.