Bug 178479 - [FrameView::layout cleanup] Use SetForScope to protect m_needsFullRepaint's value on reentrancy
Summary: [FrameView::layout cleanup] Use SetForScope to protect m_needsFullRepaint's v...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-18 11:49 PDT by zalan
Modified: 2017-10-18 15:28 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.51 KB, patch)
2017-10-18 11:52 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (2.23 KB, patch)
2017-10-18 13:00 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-18 11:49:14 PDT 
ssia.
Comment 1 Radar WebKit Bug Importer 2017-10-18 11:49:39 PDT 
<rdar://problem/35056950>
Comment 2 zalan 2017-10-18 11:52:41 PDT 
Created attachment 324144 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-10-18 12:55:26 PDT 
Comment on attachment 324144 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324144&action=review

> Source/WebCore/page/FrameView.cpp:1527
> +        SetForScope<bool> needsFullRepaint(m_needsFullRepaint);
> +        if (!isSubtreeLayout && !downcast<RenderView>(*layoutRoot).printing()) {

Can't you just move the scope inside the if () condition, rather than adding an extra set of braces?
Comment 4 zalan 2017-10-18 13:00:05 PDT 
Created attachment 324155 [details]
Patch
Comment 5 WebKit Commit Bot 2017-10-18 15:27:59 PDT 
Comment on attachment 324155 [details]
Patch

Clearing flags on attachment: 324155

Committed r223633: <https://trac.webkit.org/changeset/223633>
Comment 6 WebKit Commit Bot 2017-10-18 15:28:01 PDT 
All reviewed patches have been landed.  Closing bug.