Extend the changes made in r223307 to not update Document.lastHandledUserGestureTimestamp unless the key event is handled by the page.
<rdar://problem/34869935>
Created attachment 324136 [details] Proposed patch.
Comment on attachment 324136 [details] Proposed patch. Attachment 324136 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4905433 New failing tests: webrtc/video-replace-muted-track.html
Created attachment 324148 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
(In reply to Build Bot from comment #4) > Created attachment 324148 [details] > Archive of layout-test-results from ews123 for ios-simulator-wk2 > > The attached test failures were seen while running run-webkit-tests on the > ios-sim-ews. > Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6 This seems unrelated. The test that failed is webrtc/video-replace-muted-track.html, which is flakey on the simulator (see bug 173608).
Comment on attachment 324136 [details] Proposed patch. Looks great! r=me.
Comment on attachment 324136 [details] Proposed patch. Clearing flags on attachment: 324136 Committed r223626: <https://trac.webkit.org/changeset/223626>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35059083>
Comment on attachment 324136 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=324136&action=review > Source/WebCore/ChangeLog:13 > + (WebCore::EventHandler::keyEvent): Restore the current Document's "lastHandledUserGestureTimestamp" > + if the key event was not handled. Why not just wait to set it until afterward?