Bug 178470 - Check notifyPagesWhenTelemetryWasCaptured before notifying pages if there is no WebPageProxy
Summary: Check notifyPagesWhenTelemetryWasCaptured before notifying pages if there is ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Wilander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-18 10:00 PDT by John Wilander
Modified: 2017-10-18 11:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.42 KB, patch)
2017-10-18 10:04 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2017-10-18 10:08 PDT, John Wilander 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Wilander 2017-10-18 10:00:58 PDT 
There's a missing check of the test setting notifyPagesWhenTelemetryWasCaptured when there's no WebPageProxy and we notify pages of a zero result.
Comment 1 John Wilander 2017-10-18 10:01:16 PDT 
<rdar://problem/34417518>
Comment 2 John Wilander 2017-10-18 10:04:31 PDT 
Created attachment 324126 [details]
Patch
Comment 3 John Wilander 2017-10-18 10:08:22 PDT 
Created attachment 324127 [details]
Patch
Comment 4 BJ Burg 2017-10-18 10:51:33 PDT 
Comment on attachment 324127 [details]
Patch

r=me
Comment 5 John Wilander 2017-10-18 10:54:24 PDT 
Comment on attachment 324127 [details]
Patch

Thanks, Brian!
Comment 6 WebKit Commit Bot 2017-10-18 11:21:19 PDT 
Comment on attachment 324127 [details]
Patch

Clearing flags on attachment: 324127

Committed r223616: <https://trac.webkit.org/changeset/223616>
Comment 7 WebKit Commit Bot 2017-10-18 11:21:21 PDT 
All reviewed patches have been landed.  Closing bug.