Bug 178465 - ASSERTION FAILED: !m_layerTreeStateIsFrozen in WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer(CALayer *)
Summary: ASSERTION FAILED: !m_layerTreeStateIsFrozen in WebKit::TiledCoreAnimationDraw...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-18 09:24 PDT by Ryan Haddad
Modified: 2018-06-01 14:23 PDT (History)
6 users (show)

See Also:

Attachments
Crash log (78.61 KB, text/plain)
2017-10-18 09:24 PDT, Ryan Haddad 		no flags Details
Patch (1.50 KB, patch)
2018-05-31 16:23 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2017-10-18 09:24:46 PDT 
Created attachment 324122 [details]
Crash log

This assertion failure is seen on macOS debug bots with LayoutTest fast/html/marquee-scroll.html

ASSERTION FAILED: !m_layerTreeStateIsFrozen
/Volumes/Data/slave/elcapitan-debug/build/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm(637) : void WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer(CALayer *)
1   0x11dcdca50 WTFCrash
2   0x10b1d2593 WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer(CALayer*)
3   0x10b1d3b4e WebKit::TiledCoreAnimationDrawingArea::flushLayers()
4   0x10b1d436c non-virtual thunk to WebKit::TiledCoreAnimationDrawingArea::flushLayers()
5   0x110f93615 WebCore::LayerFlushScheduler::layerFlushCallback()
6   0x110f93d0b WebCore::LayerFlushScheduler::LayerFlushScheduler(WebCore::LayerFlushSchedulerClient*)::$_0::operator()() const
7   0x110f93c9c WTF::Function<void ()>::CallableWrapper<WebCore::LayerFlushScheduler::LayerFlushScheduler(WebCore::LayerFlushSchedulerClient*)::$_0>::call()
8   0x10f09782e WTF::Function<void ()>::operator()() const
9   0x11186f4fe WebCore::RunLoopObserver::runLoopObserverFired()
10  0x11186f480 WebCore::RunLoopObserver::runLoopObserverFired(__CFRunLoopObserver*, unsigned long, void*)
11  0x7fff9e948fc7 __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__
12  0x7fff9e948f37 __CFRunLoopDoObservers
13  0x7fff9e927e48 CFRunLoopRunSpecific
14  0x7fff9f4cf935 RunCurrentEventLoopInMode
15  0x7fff9f4cf76f ReceiveNextEventCommon
16  0x7fff9f4cf5af _BlockUntilNextEventMatchingListInModeWithFilter
17  0x7fff96047df6 _DPSNextEvent
18  0x7fff96047226 -[NSApplication _nextEventMatchingEventMask:untilDate:inMode:dequeue:]
19  0x7fff9603bd80 -[NSApplication run]
20  0x7fff96005368 NSApplicationMain
21  0x7fff91d24194 _xpc_objc_main
22  0x7fff91d22bbe xpc_main
23  0x10abb7fdd main
24  0x7fff9551c5ad start
25  0x1

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r223569%20(3681)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fhtml%2Fmarquee-scroll.html
Comment 1 Radar WebKit Bug Importer 2017-10-18 09:26:40 PDT 
<rdar://problem/35052953>
Comment 2 Ryan Haddad 2017-10-18 09:28:18 PDT 
The log attributes the crash to fast/html/marquee-reparent-check.html, which was added with https://trac.webkit.org/changeset/223313/webkit
Comment 3 Ryan Haddad 2017-10-24 13:22:25 PDT 
Skipped test in https://trac.webkit.org/changeset/223915/webkit
Comment 4 Brent Fulgham 2018-05-31 16:23:04 PDT 
Created attachment 341700 [details]
Patch
Comment 5 Geoffrey Garen 2018-05-31 17:21:52 PDT 
Comment on attachment 341700 [details]
Patch

r=me
Comment 6 WebKit Commit Bot 2018-06-01 09:00:51 PDT 
Comment on attachment 341700 [details]
Patch

Clearing flags on attachment: 341700

Committed r232395: <https://trac.webkit.org/changeset/232395>
Comment 7 WebKit Commit Bot 2018-06-01 09:00:52 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Brent Fulgham 2018-06-01 14:23:33 PDT 
(In reply to Brent Fulgham from comment #8)
> So far, showing now flakiness:

s/now/NO/

NO flakiness.