Bug 178444 - REGRESSION(r217771): nullTerminatedWCharToString loses last character of input string
Summary: REGRESSION(r217771): nullTerminatedWCharToString loses last character of inpu...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-18 05:41 PDT by Konstantin Tokarev
Modified: 2017-10-18 07:58 PDT (History)
11 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2017-10-18 05:42 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2017-10-18 05:41:22 PDT 
wcslen() returns length without terminating null character. I've put "- 1" there because originally that function was meant to be templated and operate on wchar[] literals.
Comment 1 Konstantin Tokarev 2017-10-18 05:42:30 PDT 
Created attachment 324111 [details]
Patch
Comment 2 Per Arne Vollan 2017-10-18 07:45:12 PDT 
Comment on attachment 324111 [details]
Patch

R=me.
Comment 3 Konstantin Tokarev 2017-10-18 07:57:15 PDT 
Comment on attachment 324111 [details]
Patch

Clearing flags on attachment: 324111

Committed r223606: <https://trac.webkit.org/changeset/223606>
Comment 4 Konstantin Tokarev 2017-10-18 07:57:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-10-18 07:58:04 PDT 
<rdar://problem/35051595>