178418 – Expose _boundInterfaceIdentifier and _allowsCellularAccess to WKWebsiteDataStorePrivate

RESOLVED FIXED 178418

Expose _boundInterfaceIdentifier and _allowsCellularAccess to WKWebsiteDataStorePrivate

https://bugs.webkit.org/show_bug.cgi?id=178418

Summary Expose _boundInterfaceIdentifier and _allowsCellularAccess to WKWebsiteDataSt...

Alex Christensen

Reported 2017-10-17 17:01:00 PDT

Expose _boundInterfaceIdentifier and _allowsCellularAccess to WKWebsiteDataStorePrivate

Attachments
Patch (52.30 KB, patch) 2017-10-17 18:32 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (53.19 KB, patch) 2017-10-17 18:43 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (55.21 KB, patch) 2017-10-17 19:01 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (55.47 KB, patch) 2017-10-18 10:25 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (55.51 KB, patch) 2017-10-18 10:38 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (58.59 KB, patch) 2017-10-18 11:21 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (60.36 KB, patch) 2017-10-18 12:13 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (60.84 KB, patch) 2017-10-18 12:20 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Patch (60.81 KB, patch) 2017-10-18 12:35 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (33.35 MB, application/zip) 2017-10-18 14:23 PDT, Build Bot	no flags	Details
Patch (61.05 KB, patch) 2017-10-20 13:00 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2017-10-17 18:32:11 PDT

Created attachment 324077 [details] Patch

Alex Christensen

Comment 2 2017-10-17 18:43:03 PDT

Created attachment 324079 [details] Patch

Alex Christensen

Comment 3 2017-10-17 19:01:36 PDT

Created attachment 324083 [details] Patch

Alex Christensen

Comment 4 2017-10-18 10:25:18 PDT

Created attachment 324130 [details] Patch

Alex Christensen

Comment 5 2017-10-18 10:38:07 PDT

Created attachment 324132 [details] Patch

Alex Christensen

Comment 6 2017-10-18 11:21:43 PDT

Created attachment 324139 [details] Patch

Tim Horton

Comment 7 2017-10-18 11:46:39 PDT

Comment on attachment 324139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324139&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:203 > - return _processPoolConfiguration->allowsCellularAccess(); > + return YES; The fact that there are no changes to the header to remove/deprecate/warn that these are lies is concerning.

Alex Christensen

Comment 8 2017-10-18 12:13:15 PDT

Created attachment 324145 [details] Patch

Alex Christensen

Comment 9 2017-10-18 12:20:09 PDT

Created attachment 324147 [details] Patch

Alex Christensen

Comment 10 2017-10-18 12:35:38 PDT

Created attachment 324149 [details] Patch

Build Bot

Comment 11 2017-10-18 14:23:17 PDT

Comment on attachment 324149 [details] Patch Attachment 324149 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4907596 New failing tests: http/tests/resourceLoadStatistics/add-partitioning-to-redirect.html http/tests/websocket/tests/hybi/secure-cookie-secure-connection.pl http/tests/websocket/tests/hybi/secure-cookie-insecure-connection.pl http/tests/cookies/third-party-cookie-relaxing.html imported/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/script-crossorigin-network.html http/tests/cookies/http-get-cookie-set-in-js.html http/tests/websocket/tests/hybi/httponly-cookie.pl http/tests/security/contentSecurityPolicy/report-and-enforce.php http/tests/security/svg-image-leak.html http/tests/cookies/private-cookie-storage.html http/tests/cookies/sync-xhr-set-cookie-invalidates-cache.html imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies.any.html imported/w3c/web-platform-tests/XMLHttpRequest/anonymous-mode-unsupported.htm http/tests/resourceLoadStatistics/remove-partitioning-from-redirect.html imported/w3c/web-platform-tests/fetch/api/cors/cors-cookies.any.worker.html

Build Bot

Comment 12 2017-10-18 14:23:20 PDT

Created attachment 324166 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6

Alex Christensen

Comment 13 2017-10-20 13:00:42 PDT

Created attachment 324434 [details] Patch

WebKit Commit Bot

Comment 14 2017-10-20 13:39:37 PDT

Comment on attachment 324434 [details] Patch Clearing flags on attachment: 324434 Committed r223791: <https://trac.webkit.org/changeset/223791>

WebKit Commit Bot

Comment 15 2017-10-20 13:39:39 PDT

All reviewed patches have been landed. Closing bug.

Alex Christensen

Comment 16 2017-10-20 18:11:33 PDT

http://trac.webkit.org/r223803

Radar WebKit Bug Importer

Comment 17 2017-11-15 13:10:42 PST

<rdar://problem/35568914>

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Alex Christensen

Reported

2017-10-17 17:01 PDT

Modified

2017-11-15 13:10 PST History

CC List

6 users Show

URL

Keywords InRadar

Depends on

Blocks