Bug 178417 - Some older hardware can't actually use renderbuffers at the size they advertise
Summary: Some older hardware can't actually use renderbuffers at the size they advertise
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
Keywords: InRadar
Depends on:
Reported: 2017-10-17 16:56 PDT by Dean Jackson
Modified: 2017-10-18 16:42 PDT (History)
9 users (show)

See Also:

Patch (3.68 KB, patch)
2017-10-18 15:39 PDT, Dean Jackson
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2017-10-17 16:56:55 PDT
This is failing, but only on older hardware (such as the test bots).

Checking drawingBufferWidth/drawingBufferHeight
PASS gl.drawingBufferWidth is gl.canvas.width
PASS gl.drawingBufferHeight is gl.canvas.height
PASS maxSize[0] > 0 is true
PASS maxSize[1] > 0 is true
MAX_VIEWPORT_DIMS = 16384x16384
canvas = 50x50
PASS gl.drawingBufferWidth > 0 is true
PASS gl.drawingBufferHeight > 0 is true
PASS gl.drawingBufferWidth <= maxSize[0] is true
PASS gl.drawingBufferHeight <= maxSize[1] is true
FAIL gl.getError() should be 0. Was 1286.


I assume that trying to allocate such a huge backing store is sort-of working, but not really. I haven't been able to reproduce on newer hardware yet.
Comment 1 Radar WebKit Bug Importer 2017-10-17 16:57:55 PDT
Comment 2 Dean Jackson 2017-10-18 15:34:01 PDT
Was "webgl/1.0.2/conformance/canvas/drawingbuffer-static-canvas-test.html failing"
Comment 3 Dean Jackson 2017-10-18 15:39:31 PDT
Created attachment 324176 [details]
Comment 4 Dean Jackson 2017-10-18 16:42:26 PDT
Committed r223640: <https://trac.webkit.org/changeset/223640>