RESOLVED FIXED 178414
[FrameView::layout cleanup] Remove redundant body->renderer()->setChildNeedsLayout call 
https://bugs.webkit.org/show_bug.cgi?id=178414
Summary [FrameView::layout cleanup] Remove redundant body->renderer()->setChildNeedsL...
zalan
Reported 2017-10-17 16:01:44 PDT
it's not getting executed at all.
Attachments
Patch (2.84 KB, patch)
2017-10-17 16:07 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-17 16:02:03 PDT
<rdar://problem/35040876>
zalan
Comment 2 2017-10-17 16:07:44 PDT
Created attachment 324067 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-10-17 16:45:51 PDT
Comment on attachment 324067 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324067&action=review > Source/WebCore/page/FrameView.cpp:-1444 > - if (!m_firstLayout && m_size.height() != layoutHeight() && body->renderer()->enclosingBox().stretchesToViewport()) > - body->renderer()->setChildNeedsLayout(); Does something else take care of the stretchesToViewport() case?
zalan
Comment 4 2017-10-17 18:14:33 PDT
(In reply to Simon Fraser (smfr) from comment #3) > Comment on attachment 324067 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=324067&action=review > > > Source/WebCore/page/FrameView.cpp:-1444 > > - if (!m_firstLayout && m_size.height() != layoutHeight() && body->renderer()->enclosingBox().stretchesToViewport()) > > - body->renderer()->setChildNeedsLayout(); > > Does something else take care of the stretchesToViewport() case? Yea, I tried to explain it in the Changelog entry.
WebKit Commit Bot
Comment 5 2017-10-17 18:42:29 PDT
Comment on attachment 324067 [details] Patch Clearing flags on attachment: 324067 Committed r223590: <https://trac.webkit.org/changeset/223590>
WebKit Commit Bot
Comment 6 2017-10-17 18:42:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.