Bug 178414 - [FrameView::layout cleanup] Remove redundant body->renderer()->setChildNeedsLayout call
Summary: [FrameView::layout cleanup] Remove redundant body->renderer()->setChildNeedsL...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-17 16:01 PDT by zalan
Modified: 2017-10-17 18:42 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.84 KB, patch)
2017-10-17 16:07 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-17 16:01:44 PDT
it's not getting executed at all.
Comment 1 Radar WebKit Bug Importer 2017-10-17 16:02:03 PDT
<rdar://problem/35040876>
Comment 2 zalan 2017-10-17 16:07:44 PDT
Created attachment 324067 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-10-17 16:45:51 PDT
Comment on attachment 324067 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324067&action=review

> Source/WebCore/page/FrameView.cpp:-1444
> -                    if (!m_firstLayout && m_size.height() != layoutHeight() && body->renderer()->enclosingBox().stretchesToViewport())
> -                        body->renderer()->setChildNeedsLayout();

Does something else take care of the stretchesToViewport() case?
Comment 4 zalan 2017-10-17 18:14:33 PDT
(In reply to Simon Fraser (smfr) from comment #3)
> Comment on attachment 324067 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=324067&action=review
> 
> > Source/WebCore/page/FrameView.cpp:-1444
> > -                    if (!m_firstLayout && m_size.height() != layoutHeight() && body->renderer()->enclosingBox().stretchesToViewport())
> > -                        body->renderer()->setChildNeedsLayout();
> 
> Does something else take care of the stretchesToViewport() case?

Yea, I tried to explain it in the Changelog entry.
Comment 5 WebKit Commit Bot 2017-10-17 18:42:29 PDT
Comment on attachment 324067 [details]
Patch

Clearing flags on attachment: 324067

Committed r223590: <https://trac.webkit.org/changeset/223590>
Comment 6 WebKit Commit Bot 2017-10-17 18:42:31 PDT
All reviewed patches have been landed.  Closing bug.