Bug 178411 - [iOS] Don't turn fields yellow after filling credentials
Summary: [iOS] Don't turn fields yellow after filling credentials
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-17 15:42 PDT by Chelsea Pugh
Modified: 2017-10-17 16:38 PDT (History)
6 users (show)

See Also:

Attachments
Patch for [iOS] Don't turn fields yellow after filling credentials (1.45 KB, patch)
2017-10-17 15:45 PDT, Chelsea Pugh 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chelsea Pugh 2017-10-17 15:42:03 PDT 
Don't turn fields yellow after filling credentials
Comment 1 Chelsea Pugh 2017-10-17 15:45:58 PDT 
Created attachment 324066 [details]
Patch for [iOS] Don't turn fields yellow after filling credentials
Comment 2 Wenson Hsieh 2017-10-17 16:10:01 PDT 
Comment on attachment 324066 [details]
Patch for [iOS] Don't turn fields yellow after filling credentials

rs=me.
Comment 3 Tim Horton 2017-10-17 16:13:00 PDT 
Comment on attachment 324066 [details]
Patch for [iOS] Don't turn fields yellow after filling credentials

View in context: https://bugs.webkit.org/attachment.cgi?id=324066&action=review

> Source/WebCore/ChangeLog:5
> +

rdar://?

> Source/WebCore/editing/ios/AutofillElements.cpp:-124
> -        m_username->setAutoFilled();

Do we still need the underlying mechanism?
Comment 4 WebKit Commit Bot 2017-10-17 16:38:30 PDT 
Comment on attachment 324066 [details]
Patch for [iOS] Don't turn fields yellow after filling credentials

Clearing flags on attachment: 324066

Committed r223585: <https://trac.webkit.org/changeset/223585>
Comment 5 WebKit Commit Bot 2017-10-17 16:38:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-17 16:38:55 PDT 
<rdar://problem/35041874>