Bug 178407 – [GTK][Stable] BackingStoreBackendCairoImpl.h:23:10: fatal error: WebCore/HysteresisActivity.h

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

I tried to build webkitgtk+ ver 2.18.0 with cairo on macos10.13.

>BackingStoreBackendCairoImpl.h:23:10: fatal error: WebCore/HysteresisActivity.h

Please change in Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.h at line 23.

- #include <WebCore/HysteresisActivity.h>
+ #include <WebCore/platform/HysteresisActivity.h>

[Michael Catanzaro]

Thanks for this bug report.

(In reply to s172262 from comment #0)
> I tried to build webkitgtk+ ver 2.18.0 with cairo on macos10.13.
> 
> >BackingStoreBackendCairoImpl.h:23:10: fatal error: WebCore/HysteresisActivity.h
> 
> Please change in
> Source/WebCore/platform/graphics/cairo/BackingStoreBackendCairoImpl.h at
> line 23.
> 
> - #include <WebCore/HysteresisActivity.h>
> + #include <WebCore/platform/HysteresisActivity.h>

WebKit coding style is to add the right include directories, so that full paths are not required. So the right fix is to add the right include path in some CMake file somewhere. Can't tell where without more of a build log to see where BackingStoreBackendCairoImpl.h is being included from. But it's very, very odd that WebCore/platform would not already be in the include path.

Anyway, HysteresisActivity has been moved to PAL in trunk, so it'll need to be fixed separately for 2.18. We're not going to fix it ourselves as we don't actually develop or support WebKitGTK+ on Mac, but we do consider community patches when posted following the guidance at https://webkit.org/contributing-code/#create-the-patch if you want to take a stab at it.

> We're not going to fix it ourselves as we don't actually develop or support WebKitGTK+ on Mac,
> but we do consider community patches when posted following the guidance at
> https://webkit.org/contributing-code/#create-the-patch if you want to take a  stab at it.

I know this isn't only MacOS's matter.

See https://www.mail-archive.com/[e-mail]/msg17290.html
and https://lists.nongnu.org/archive/html/bug-guix/2017-10/msg00083.html

[Carlos Alberto Lopez Perez]

I think the fix may be to include the header quoted as the include is from a header or WebCore into another of WebCore.

Can you check if this will fix the issue?

- #include <WebCore/HysteresisActivity.h>
+ #include "HysteresisActivity.h"

[Carlos Garcia Campos]

Created attachment 324099 [details]
Patch

This is for 2.18, it won't apply in trunk

[Carlos Garcia Campos]

Committed r223597

[Carlos Alberto Lopez Perez]

The fix was merged on WebKitGTK+ 2.18.1 that was released a few hours ago.