Bug 178401 - [FrameView::layout cleanup] Subtree should read subtreeLayout.
Summary: [FrameView::layout cleanup] Subtree should read subtreeLayout.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-17 11:20 PDT by zalan
Modified: 2017-10-17 13:09 PDT (History)
6 users (show)

See Also:

Attachments
Patch (21.52 KB, patch)
2017-10-17 11:41 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (21.45 KB, patch)
2017-10-17 12:41 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-17 11:20:01 PDT 
and m_layoutRoot -> m_subtreeLayoutRoot
Comment 1 Radar WebKit Bug Importer 2017-10-17 11:21:39 PDT 
<rdar://problem/35033431>
Comment 2 zalan 2017-10-17 11:41:15 PDT 
Created attachment 324033 [details]
Patch
Comment 3 Simon Fraser (smfr) 2017-10-17 11:44:15 PDT 
Comment on attachment 324033 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324033&action=review

> Source/WebCore/page/FrameView.cpp:1359
> +        if (!layoutRoot || !layoutRoot->needsLayout())

Kinda weird that we can have a m_subtreeLayoutRoot with needsLayout() == false (if that happens).

> Source/WebCore/page/FrameView.cpp:1392
> +    bool performingSubtreeLayout = false;

or isSubtreeLayout?

> Source/WebCore/page/FrameView.cpp:1505
> +        ASSERT(allowSubtreeLayout || !performingSubtreeLayout);

Said added ASSERT_IMPLIES which would be appropriate here: ASSERT_IMPLIES(performingSubtreeLayout, allowSubtreeLayout)
Comment 4 zalan 2017-10-17 12:41:59 PDT 
Created attachment 324043 [details]
Patch
Comment 5 WebKit Commit Bot 2017-10-17 13:09:19 PDT 
Comment on attachment 324043 [details]
Patch

Clearing flags on attachment: 324043

Committed r223569: <https://trac.webkit.org/changeset/223569>
Comment 6 WebKit Commit Bot 2017-10-17 13:09:20 PDT 
All reviewed patches have been landed.  Closing bug.