RESOLVED FIXED 178401
[FrameView::layout cleanup] Subtree should read subtreeLayout. 
https://bugs.webkit.org/show_bug.cgi?id=178401
Summary [FrameView::layout cleanup] Subtree should read subtreeLayout.
zalan
Reported 2017-10-17 11:20:01 PDT
and m_layoutRoot -> m_subtreeLayoutRoot
Attachments
Patch (21.52 KB, patch)
2017-10-17 11:41 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (21.45 KB, patch)
2017-10-17 12:41 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-17 11:21:39 PDT
<rdar://problem/35033431>
zalan
Comment 2 2017-10-17 11:41:15 PDT
Created attachment 324033 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-10-17 11:44:15 PDT
Comment on attachment 324033 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324033&action=review > Source/WebCore/page/FrameView.cpp:1359 > + if (!layoutRoot || !layoutRoot->needsLayout()) Kinda weird that we can have a m_subtreeLayoutRoot with needsLayout() == false (if that happens). > Source/WebCore/page/FrameView.cpp:1392 > + bool performingSubtreeLayout = false; or isSubtreeLayout? > Source/WebCore/page/FrameView.cpp:1505 > + ASSERT(allowSubtreeLayout || !performingSubtreeLayout); Said added ASSERT_IMPLIES which would be appropriate here: ASSERT_IMPLIES(performingSubtreeLayout, allowSubtreeLayout)
zalan
Comment 4 2017-10-17 12:41:59 PDT
Created attachment 324043 [details] Patch
WebKit Commit Bot
Comment 5 2017-10-17 13:09:19 PDT
Comment on attachment 324043 [details] Patch Clearing flags on attachment: 324043 Committed r223569: <https://trac.webkit.org/changeset/223569>
WebKit Commit Bot
Comment 6 2017-10-17 13:09:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.