Bug 178394 - [FrameView::layout cleanup] Move scrollbars setup logic to a separate function
Summary: [FrameView::layout cleanup] Move scrollbars setup logic to a separate function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-17 09:49 PDT by zalan
Modified: 2017-10-19 14:23 PDT (History)
8 users (show)

See Also:

Attachments
Patch (5.70 KB, patch)
2017-10-17 09:57 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.62 KB, patch)
2017-10-17 11:01 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.57 KB, patch)
2017-10-17 11:53 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (5.58 KB, patch)
2017-10-17 12:39 PDT, zalan 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews117 for mac-elcapitan (1.84 MB, application/zip)
2017-10-17 13:47 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews101 for mac-elcapitan (1.06 MB, application/zip)
2017-10-17 13:50 PDT, Build Bot 		no flags Details
Patch (5.52 KB, patch)
2017-10-19 12:25 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-17 09:49:57 PDT 
from FrameView::layout
Comment 1 Radar WebKit Bug Importer 2017-10-17 09:50:25 PDT 
<rdar://problem/35031066>
Comment 2 zalan 2017-10-17 09:57:02 PDT 
Created attachment 324020 [details]
Patch
Comment 3 zalan 2017-10-17 11:01:38 PDT 
Created attachment 324030 [details]
Patch
Comment 4 Simon Fraser (smfr) 2017-10-17 11:40:58 PDT 
Comment on attachment 324030 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324030&action=review

> Source/WebCore/page/FrameView.cpp:1325
> +void FrameView::adjustScrollbarsForLayout(bool firstLayout, const RenderElement& layoutRoot)

Weird to pass in layoutRoot just to have a way to get a Page&.
Comment 5 zalan 2017-10-17 11:53:52 PDT 
Created attachment 324037 [details]
Patch
Comment 6 Antti Koivisto 2017-10-17 12:09:04 PDT 
Comment on attachment 324037 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324037&action=review

> Source/WebCore/page/FrameView.cpp:1325
> +void FrameView::adjustScrollbarsForLayout(bool firstLayout)

isFirstLayout would be more along WebKit style.
Comment 7 zalan 2017-10-17 12:39:12 PDT 
Created attachment 324041 [details]
Patch
Comment 8 Build Bot 2017-10-17 13:47:40 PDT 
Comment on attachment 324041 [details]
Patch

Attachment 324041 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4888125

New failing tests:
http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html
Comment 9 Build Bot 2017-10-17 13:47:45 PDT 
Created attachment 324050 [details]
Archive of layout-test-results from ews117 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Build Bot 2017-10-17 13:50:06 PDT 
Comment on attachment 324041 [details]
Patch

Attachment 324041 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4888464

New failing tests:
http/tests/loading/unfinished-main-resource-back-to-cached-page-callbacks.html
Comment 11 Build Bot 2017-10-17 13:50:07 PDT 
Created attachment 324051 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 12 zalan 2017-10-19 12:25:33 PDT 
Created attachment 324263 [details]
Patch
Comment 13 WebKit Commit Bot 2017-10-19 14:23:17 PDT 
Comment on attachment 324263 [details]
Patch

Clearing flags on attachment: 324263

Committed r223712: <https://trac.webkit.org/changeset/223712>
Comment 14 WebKit Commit Bot 2017-10-19 14:23:19 PDT 
All reviewed patches have been landed.  Closing bug.