Bug 178391 - [FrameView::layout cleanup] Move text auto sizing logic to a separate function
Summary: [FrameView::layout cleanup] Move text auto sizing logic to a separate function
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-17 09:08 PDT by zalan
Modified: 2017-10-17 11:11 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2017-10-17 09:12 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-17 09:08:30 PDT 
from FrameView::layout
Comment 1 Radar WebKit Bug Importer 2017-10-17 09:08:53 PDT 
<rdar://problem/35030264>
Comment 2 zalan 2017-10-17 09:12:31 PDT 
Created attachment 324017 [details]
Patch
Comment 3 Antti Koivisto 2017-10-17 09:14:17 PDT 
Comment on attachment 324017 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2017-10-17 09:34:49 PDT 
Comment on attachment 324017 [details]
Patch

Clearing flags on attachment: 324017

Committed r223551: <https://trac.webkit.org/changeset/223551>
Comment 5 WebKit Commit Bot 2017-10-17 09:34:50 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Fraser (smfr) 2017-10-17 11:11:07 PDT 
Comment on attachment 324017 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=324017&action=review

> Source/WebCore/page/FrameView.cpp:1304
> +static void applyTextSizingIfNeeded(RenderElement& layoutRoot)

I wonder if this name should make it more clear that it does another layout. Maybe relayoutApplyingTextAutoSizingIfNeeded ?