RESOLVED FIXED 178391
[FrameView::layout cleanup] Move text auto sizing logic to a separate function 
https://bugs.webkit.org/show_bug.cgi?id=178391
Summary [FrameView::layout cleanup] Move text auto sizing logic to a separate function
zalan
Reported 2017-10-17 09:08:30 PDT
from FrameView::layout
Attachments
Patch (3.28 KB, patch)
2017-10-17 09:12 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-17 09:08:53 PDT
<rdar://problem/35030264>
zalan
Comment 2 2017-10-17 09:12:31 PDT
Created attachment 324017 [details] Patch
Antti Koivisto
Comment 3 2017-10-17 09:14:17 PDT
Comment on attachment 324017 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-10-17 09:34:49 PDT
Comment on attachment 324017 [details] Patch Clearing flags on attachment: 324017 Committed r223551: <https://trac.webkit.org/changeset/223551>
WebKit Commit Bot
Comment 5 2017-10-17 09:34:50 PDT
All reviewed patches have been landed. Closing bug.
Simon Fraser (smfr)
Comment 6 2017-10-17 11:11:07 PDT
Comment on attachment 324017 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324017&action=review > Source/WebCore/page/FrameView.cpp:1304 > +static void applyTextSizingIfNeeded(RenderElement& layoutRoot) I wonder if this name should make it more clear that it does another layout. Maybe relayoutApplyingTextAutoSizingIfNeeded ?
Note You need to log in before you can comment on or make changes to this bug.