Bug 178374 - ServiceWorkerRegistration should subclass RefCounted<>
Summary: ServiceWorkerRegistration should subclass RefCounted<>
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Keywords: InRadar
Depends on:
Reported: 2017-10-16 20:41 PDT by Chris Dumez
Modified: 2017-10-16 22:14 PDT (History)
6 users (show)

See Also:

Patch (2.12 KB, patch)
2017-10-16 20:44 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (2.12 KB, patch)
2017-10-16 21:32 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-16 20:41:24 PDT
ServiceWorkerRegistration should subclass RefCounted<>.
Comment 1 Chris Dumez 2017-10-16 20:44:27 PDT
Created attachment 323982 [details]
Comment 2 Ryosuke Niwa 2017-10-16 20:47:44 PDT
Comment on attachment 323982 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=323982&action=review

> Source/WebCore/workers/service/ServiceWorkerRegistration.h:40
> -class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject {
> +class ServiceWorkerRegistration final : public EventTargetWithInlineData, public ActiveDOMObject, public RefCounted<ServiceWorkerRegistration> {

We typically put RefCounted as the first class listed in the inheritance list.
Comment 3 Chris Dumez 2017-10-16 21:32:38 PDT
Created attachment 323991 [details]
Comment 4 WebKit Commit Bot 2017-10-16 22:12:56 PDT
Comment on attachment 323991 [details]

Clearing flags on attachment: 323991

Committed r223457: <https://trac.webkit.org/changeset/223457>
Comment 5 WebKit Commit Bot 2017-10-16 22:12:57 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-16 22:14:18 PDT