run-webkit-tests help text should mention arguments too
Created attachment 323915 [details]
This is using the deprecated optparse instead of argparse, so apparently the only way to document arguments is by writing the Usage line manually.
Still, this is an improvement for people just getting started with LayoutTests.
Comment on attachment 323915 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=323915&action=review
> + option_parser = optparse.OptionParser(usage="run_webkit_tests.py [options] [<path>...]")
Technically run_webkit_tests.py should be %prog
Though oddly it shows the .py even though I'm running it as 'run-webkit-tests', so maybe this is already broken somehow.
Created attachment 323919 [details]
Comment on attachment 323919 [details]
Clearing flags on attachment: 323919
Committed r223429: <https://trac.webkit.org/changeset/223429>
All reviewed patches have been landed. Closing bug.
What is the observable effect of this change? There was a lot of documentation about arguments printed by run-webkit-tests —help already.
(In reply to Alexey Proskuryakov from comment #9)
> What is the observable effect of this change? There was a lot of
> documentation about arguments printed by run-webkit-tests —help already.
This just changes the very first line, which previously didn’t mention the fact that you can pass test paths.