Bug 178344 – [GStreamer][MSE] Microgardening

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Alicia Boya García]

I'm updating the expectations of a few tests so I can know more easily when I'm
causing a regression or actually fixing something.

Changes:

* LayoutTests/imported/w3c/web-platform-tests/media-source/mediasource-is-type-supported-expected.txt

  Updated with current output (as a prerequisite to land this
  https://bugs.webkit.org/show_bug.cgi?id=178160, which improves the -expected
  output a bit)

* imported/w3c/web-platform-tests/media-source/SourceBuffer-abort*.html

  Marking them as passing, as they have been passing for a while.

* imported/w3c/web-platform-tests/media-source/mediasource-play-then-seek-back.html
  imported/w3c/web-platform-tests/media-source/mediasource-sourcebuffer-mode.html

  Marking them as passing. They were crashing on the build bot because the
  changes of https://bugs.webkit.org/show_bug.cgi?id=176804 were not being built,
  but Carlos López is already working on that.

[Alicia Boya García]

Created attachment 323903 [details]
Patch

[Carlos Alberto Lopez Perez]

Comment on attachment 323903 [details]
Patch

I think commit-queue is going to reject this because it doesn't contain the word unreviewed on the changelog neither the usual oops line for the reviewer line ... but let's try

[WebKit Commit Bot]

Comment on attachment 323903 [details]
Patch

Rejecting attachment 323903 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 323903, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/LayoutTests/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/4872097

[Alicia Boya García]

Created attachment 323911 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 323911 [details]
Patch

Clearing flags on attachment: 323911

Committed r223477: <https://trac.webkit.org/changeset/223477>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.