Guessing MIME type from a file extension in a URL is wrong
Created attachment 323880 [details] For EWS testing
Attachment 323880 [details] did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 325547 [details] Patch
Created attachment 325549 [details] Patch
Comment on attachment 325549 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325549&action=review > Source/WebCore/ChangeLog:3 > + Guessing MIME type from a file extension in a URL is wrong It would be helpful if the title somehow conveyed that this is about plug-ins, and that there is no observable difference expected.
Created attachment 325650 [details] Patch for landing
Comment on attachment 325650 [details] Patch for landing Rejecting attachment 325650 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: c /Volumes/Data/EWS/WebKit/Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp -o /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/UserMediaCaptureManagerProxy.o ** BUILD FAILED ** The following build commands failed: CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKit.build/Release/WebKit.build/Objects-normal/x86_64/PluginView.o WebProcess/Plugins/PluginView.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler (1 failure) Full output: http://webkit-queues.webkit.org/results/5068376
Created attachment 325854 [details] Patch for landing
Comment on attachment 325854 [details] Patch for landing Rejecting attachment 325854 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 325854, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebKit/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/5086167
Created attachment 325855 [details] Patch for landing
Comment on attachment 325855 [details] Patch for landing Clearing flags on attachment: 325855 Committed r224387: <https://trac.webkit.org/changeset/224387>
All reviewed patches have been landed. Closing bug.
<rdar://problem/35568740>