Bug 178325 - Web Inspector: scrolling the editor while debugging shouldn't trigger popovers
Summary: Web Inspector: scrolling the editor while debugging shouldn't trigger popovers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-15 19:55 PDT by Matt Baker
Modified: 2019-06-19 14:36 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.81 KB, patch)
2017-10-15 19:57 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Baker 2017-10-15 19:55:00 PDT 
Summary:
Scrolling the editor while debugging shouldn't trigger popovers.

After one or more mousewheel events, a single mousemove event is fired. This causes the CodeMirrorTokenTrackingController to display a popover if a token comes to rest under the cursor. This can be *extremely* distracting when reading/scrolling code while the debugger is paused.

It also causes a situation where popovers can appear while the mouse cursor is hidden.

Steps to Reproduce:
1. Pause in the debugger
2. Cursor around in the editor using the arrow keys
  => The mouse cursor disappears
3. Scroll the editor using the trackpad/mouse wheel, a few lines at a time
  => Popover eventually appears once hidden cursor comes to rest over a token
Comment 1 Matt Baker 2017-10-15 19:57:45 PDT 
Created attachment 323863 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2017-10-15 19:58:57 PDT 
<rdar://problem/35000636>
Comment 3 Devin Rousso 2017-10-20 21:40:03 PDT 
Comment on attachment 323863 [details]
Patch

r=me.  Nice!  I've definitely run into this issue before :P
Comment 4 WebKit Commit Bot 2017-10-20 22:04:32 PDT 
Comment on attachment 323863 [details]
Patch

Clearing flags on attachment: 323863

Committed r223807: <https://trac.webkit.org/changeset/223807>
Comment 5 WebKit Commit Bot 2017-10-20 22:04:33 PDT 
All reviewed patches have been landed.  Closing bug.