Bug 178324 - Make some asserts into release asserts
Summary: Make some asserts into release asserts
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-15 19:34 PDT by Filip Pizlo
Modified: 2017-10-20 17:42 PDT (History)
12 users (show)

See Also:


Attachments
the patch (16.42 KB, patch)
2017-10-15 19:36 PDT, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-10-15 19:34:51 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2017-10-15 19:36:23 PDT
Created attachment 323861 [details]
the patch
Comment 2 Radar WebKit Bug Importer 2017-10-15 19:36:47 PDT
<rdar://problem/35000510>
Comment 3 Filip Pizlo 2017-10-16 10:19:28 PDT
Landed in http://trac.webkit.org/changeset/223415/webkit
Comment 4 Ryosuke Niwa 2017-10-20 17:42:34 PDT
Comment on attachment 323861 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323861&action=review

> Source/WebCore/dom/ContainerNodeAlgorithms.cpp:88
> -    ASSERT_WITH_SECURITY_IMPLICATION(NoEventDispatchAssertion::isEventDispatchAllowedInSubtree(insertionPoint));
> +    RELEASE_ASSERT(NoEventDispatchAssertion::isEventDispatchAllowedInSubtree(insertionPoint));

This is useless because NoEventDispatchAssertion is not enabled in release builds.