Bug 178318 – Web Inspector: Storage: values truncated in Local/Session table

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Ricci Adams]

When a Value in the Local Storage / Session Storage is long and truncated, Both "Copy Value" and "Copy Table" copy the truncated string with trailing ellipses, not the actual value.

Steps to Reproduce:
1. Serialize a large object via JSON.stringify and store it via window.localStorage
2. View Local Storage in Web Inspector
3. Attempt to copy the value via "Copy Table" or "Copy Row"

Expected Result:
Actual value is copied

Actual Result:
Truncated value is copied with trailing ellipses

[Blaze Burg]

Does this reproduce in Safari Technology Preview?

[Radar WebKit Bug Importer]

<rdar://problem/34998581>

[Joseph Pecoraro]

(In reply to Brian Burg from comment #1)
> Does this reproduce in Safari Technology Preview?

Yes.

[Joseph Pecoraro]

DOMStorageContentView.prototype._populate creates DataGridNodes with truncated values (length 200). Copy Row then copies the DataGridNode's data values, which is this truncated string. Likewise double click to edit gets the truncated value.

[Devin Rousso]

Created attachment 366437 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 366437 [details]
Patch

I believe this was done for some performance reason (when very large values are stored in the table. Does this regress something?

[Timothy Hatcher]

(In reply to Joseph Pecoraro from comment #6)
> Comment on attachment 366437 [details]
> Patch
> 
> I believe this was done for some performance reason (when very large values
> are stored in the table. Does this regress something?

Joe is right, that is why.

[Joseph Pecoraro]

Comment on attachment 366437 [details]
Patch

Clearing review until:

    (1) we find a solution that solves both the performance and selection issue
    (2) we make a decision that selection is more important than performance

[Ricci Adams]

This still affects my workflow all the time. Could the full value be re-fetched in response to a Copy command?

[Joseph Pecoraro]

(In reply to Ricci Adams from comment #9)
> This still affects my workflow all the time. Could the full value be
> re-fetched in response to a Copy command?

That is a good idea! We should be able to override Copy in this table to get the full value and not the truncated string being displayed.

[Devin Rousso]

Created attachment 367504 [details]
Patch

[Joseph Pecoraro]

Comment on attachment 367504 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 367504 [details]
Patch

Clearing flags on attachment: 367504

Committed r244350: <https://trac.webkit.org/changeset/244350>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.