Bug 178308 - [JSC] modules can be visited more than once when resolving bindings through "star" exports as long as the exportName is different each time
Summary: [JSC] modules can be visited more than once when resolving bindings through "...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-14 09:45 PDT by Yusuke Suzuki
Modified: 2017-11-15 13:04 PST (History)
8 users (show)

See Also:

Attachments
Patch (9.51 KB, patch)
2017-10-15 21:52 PDT, Yusuke Suzuki 		mark.lam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-10-14 09:45:42 PDT 
...
Comment 2 Yusuke Suzuki 2017-10-15 21:52:18 PDT 
Created attachment 323872 [details]
Patch
Comment 3 Yusuke Suzuki 2017-10-22 06:13:35 PDT 
Ping?
Comment 4 Mark Lam 2017-10-24 09:57:45 PDT 
Comment on attachment 323872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323872&action=review

r=me

> Source/JavaScriptCore/ChangeLog:8
> +        With the change of the spec[1], we now do not need to remember star resoluted modules.

I would say "resolved" instead of "resoluted".
Comment 5 Mark Lam 2017-10-24 09:59:15 PDT 
(In reply to Mark Lam from comment #4)
> > Source/JavaScriptCore/ChangeLog:8
> > +        With the change of the spec[1], we now do not need to remember star resoluted modules.
> 
> I would say "resolved" instead of "resoluted".

Or "star resolution" also works.
Comment 6 Yusuke Suzuki 2017-10-24 10:11:36 PDT 
Comment on attachment 323872 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323872&action=review

Thanks!

>> Source/JavaScriptCore/ChangeLog:8
>> +        With the change of the spec[1], we now do not need to remember star resoluted modules.
> 
> I would say "resolved" instead of "resoluted".

star resolution sounds good. Fixed.
Comment 7 Yusuke Suzuki 2017-10-24 10:11:47 PDT 
Committed r223894: <https://trac.webkit.org/changeset/223894>
Comment 8 Radar WebKit Bug Importer 2017-11-15 13:04:28 PST 
<rdar://problem/35568734>