Bug 178306 - Use auto/nullptr in scrolling code
Summary: Use auto/nullptr in scrolling code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-14 08:12 PDT by Frédéric Wang (:fredw)
Modified: 2017-10-16 00:59 PDT (History)
10 users (show)

See Also:

Attachments
Patch (32.22 KB, patch)
2017-10-14 08:16 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (32.27 KB, patch)
2017-10-16 00:49 PDT, Frédéric Wang (:fredw) 		cgarcia: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2017-10-14 08:12:32 PDT 
Use auto/nullptr in scrolling code
Comment 1 Frédéric Wang (:fredw) 2017-10-14 08:16:55 PDT 
Created attachment 323809 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2017-10-16 00:49:54 PDT 
Created attachment 323878 [details]
Patch

Alternative version, with "auto*" used for pointers.
Comment 3 Carlos Garcia Campos 2017-10-16 00:52:59 PDT 
Comment on attachment 323878 [details]
Patch

It seems this no longer applies
Comment 4 Frédéric Wang (:fredw) 2017-10-16 00:55:01 PDT 
(In reply to Carlos Garcia Campos from comment #3)
> Comment on attachment 323878 [details]
> Patch
> 
> It seems this no longer applies

Yes, because of r223337. I'll update the patch.
Comment 5 Frédéric Wang (:fredw) 2017-10-16 00:58:22 PDT 
Committed r223339: <https://trac.webkit.org/changeset/223339>
Comment 6 Radar WebKit Bug Importer 2017-10-16 00:59:08 PDT 
<rdar://problem/35002866>