Bug 178299 - Adopt type trait template aliases everywhere in WTF
Summary: Adopt type trait template aliases everywhere in WTF
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-13 16:04 PDT by Sam Weinig
Modified: 2017-10-18 11:23 PDT (History)
9 users (show)

See Also:

Attachments
Patch (57.65 KB, patch)
2017-10-13 16:20 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-10-13 16:04:45 PDT 
Adopt type trait template aliases everywhere in WTF
Comment 1 Sam Weinig 2017-10-13 16:20:59 PDT 
Created attachment 323766 [details]
Patch
Comment 2 Build Bot 2017-10-13 16:23:15 PDT 
Attachment 323766 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Atomics.h:382:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/Atomics.h:382:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/Atomics.h:403:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WTF/wtf/Atomics.h:403:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 4 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Yusuke Suzuki 2017-10-13 21:17:32 PDT 
Comment on attachment 323766 [details]
Patch

r=me, nice!
Comment 4 WebKit Commit Bot 2017-10-13 21:45:23 PDT 
Comment on attachment 323766 [details]
Patch

Clearing flags on attachment: 323766

Committed r223316: <https://trac.webkit.org/changeset/223316>
Comment 5 WebKit Commit Bot 2017-10-13 21:45:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-13 21:46:29 PDT 
<rdar://problem/34992048>
Comment 7 Andy Estes 2017-10-18 11:23:45 PDT 
Rolled out in r223617: <https://trac.webkit.org/changeset/223617>

See rdar://problem/35047351 for details.