Bug 178285 - webrtc/datachannel/basic-tcp.html will crash with an invalid crash
Summary: webrtc/datachannel/basic-tcp.html will crash with an invalid crash
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Keywords: InRadar
Depends on:
Reported: 2017-10-13 14:09 PDT by Matt Lewis
Modified: 2018-11-07 17:34 PST (History)
9 users (show)

See Also:

Patch (3.37 KB, patch)
2018-04-09 13:29 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2018-11-06 18:27 PST, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lewis 2017-10-13 14:09:44 PDT
webrtc/datachannel/basic-tcp.html crashes on all platforms but does not have a valid crash log on Mac platforms.


Example results:

No crash log found for com.apple.WebKit.Networking.Development:423.

While not extremely flaky, this does cause the trees to go red occasionally.
Comment 1 Radar WebKit Bug Importer 2017-10-13 14:10:19 PDT
Comment 2 Jonathan Bedard 2017-10-13 14:25:40 PDT
Here's the build: <https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20%28Tests%29/builds/5007>

Something strange if definitely going on.  I would expect us to pick up a crash-log from the networking process.  It's almost as if the networking process is being killed rather than crashing.
Comment 3 Alexey Proskuryakov 2017-10-13 15:58:40 PDT
This is somewhat reproducible, but hard to catch in a debugger:

run-webkit-tests webrtc/datachannel/basic-tcp.html --repeat 1000 --no-show --no-build --no-timeout -f

I may have caught this in debugger once, the Networking process died because of a SIGPIPE. The symptom matches, although this could be a user error.
Comment 4 Alexey Proskuryakov 2017-10-13 17:23:15 PDT
Definitely SIGPIPE, sent from the Networking process itself. It looks like libwebrtc tries to handle this signal in a couple places, but that's not quite working.

I couldn't get a good stack trace for where the signal is sent from, my probe prints unsymbolicated traces for some reason.

sudo dtrace -n 'proc:::signal-send /pid/ { printf("%d %s -%d %d",pid,execname,args[2],args[1]->pr_pid); ustack(); }'
Comment 5 Alexey Proskuryakov 2018-03-12 09:47:22 PDT
A reproducible crash in a test with "basic" in its name seems particularly worth looking into.
Comment 6 youenn fablet 2018-04-09 13:29:37 PDT
Created attachment 337534 [details]
Comment 7 WebKit Commit Bot 2018-04-10 14:13:20 PDT
Comment on attachment 337534 [details]

Clearing flags on attachment: 337534

Committed r230492: <https://trac.webkit.org/changeset/230492>
Comment 8 WebKit Commit Bot 2018-04-10 14:13:21 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 youenn fablet 2018-11-06 18:27:41 PST
Reopening to attach new patch.
Comment 10 youenn fablet 2018-11-06 18:27:45 PST
Created attachment 354042 [details]
Comment 11 WebKit Commit Bot 2018-11-07 17:34:41 PST
Comment on attachment 354042 [details]

Clearing flags on attachment: 354042

Committed r237970: <https://trac.webkit.org/changeset/237970>
Comment 12 WebKit Commit Bot 2018-11-07 17:34:42 PST
All reviewed patches have been landed.  Closing bug.