Remove Editor::simplifyMarkup

[Alex Christensen]

Remove Editor::simplifyMarkup

[Alex Christensen]

Created attachment 323708 [details]
Patch

[Alex Christensen]

This was used in Mountain Lion, Mavericks, and Yosemite, but not since then.

[Wenson Hsieh]

Comment on attachment 323708 [details]
Patch

I think it would be good to mention <rdar://problem/10726177>, and the fact that Mail stopped using this SPI long ago, in the ChangeLog.

[Alex Christensen]

http://trac.webkit.org/r223291

[Radar WebKit Bug Importer]

<rdar://problem/34981927>

[Darin Adler]

Comment on attachment 323708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323708&action=review

> Source/WebKitLegacy/mac/WebView/WebView.mm:8535
>  - (void)_simplifyMarkup:(DOMNode *)startNode endNode:(DOMNode *)endNode
>  {
> -    Frame* coreFrame = core([self mainFrame]);
> -    if (!coreFrame || !startNode)
> -        return;
> -    Node* coreStartNode= core(startNode);
> -    if (&coreStartNode->document() != coreFrame->document())
> -        return;
> -    return coreFrame->editor().simplifyMarkup(coreStartNode, core(endNode));    
>  }

What is the plan here? When will we remove the method too and not just its implementation?

[Alex Christensen]

(In reply to Darin Adler from comment #6)
> What is the plan here? When will we remove the method too and not just its
> implementation?
We reverted this change.  Dan wants to keep using this method.