RESOLVED FIXED Bug 178271
Remove Editor::simplifyMarkup 
https://bugs.webkit.org/show_bug.cgi?id=178271
Summary Remove Editor::simplifyMarkup
Alex Christensen
Reported 2017-10-13 11:07:12 PDT
Remove Editor::simplifyMarkup
Attachments
Patch (13.25 KB, patch)
2017-10-13 11:08 PDT, Alex Christensen 		wenson_hsieh: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2017-10-13 11:08:33 PDT
Created attachment 323708 [details] Patch
Alex Christensen
Comment 2 2017-10-13 11:13:04 PDT
This was used in Mountain Lion, Mavericks, and Yosemite, but not since then.
Wenson Hsieh
Comment 3 2017-10-13 11:20:11 PDT
Comment on attachment 323708 [details] Patch I think it would be good to mention <rdar://problem/10726177>, and the fact that Mail stopped using this SPI long ago, in the ChangeLog.
Alex Christensen
Comment 4 2017-10-13 11:23:28 PDT
http://trac.webkit.org/r223291
Radar WebKit Bug Importer
Comment 5 2017-10-13 11:24:17 PDT
<rdar://problem/34981927>
Darin Adler
Comment 6 2017-10-15 08:34:55 PDT
Comment on attachment 323708 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=323708&action=review > Source/WebKitLegacy/mac/WebView/WebView.mm:8535 > - (void)_simplifyMarkup:(DOMNode *)startNode endNode:(DOMNode *)endNode > { > - Frame* coreFrame = core([self mainFrame]); > - if (!coreFrame || !startNode) > - return; > - Node* coreStartNode= core(startNode); > - if (&coreStartNode->document() != coreFrame->document()) > - return; > - return coreFrame->editor().simplifyMarkup(coreStartNode, core(endNode)); > } What is the plan here? When will we remove the method too and not just its implementation?
Alex Christensen
Comment 7 2017-10-31 17:41:27 PDT
(In reply to Darin Adler from comment #6) > What is the plan here? When will we remove the method too and not just its > implementation? We reverted this change. Dan wants to keep using this method.
Note You need to log in before you can comment on or make changes to this bug.