Bug 178265 - Allow modern decoding of URLs
Summary: Allow modern decoding of URLs
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2017-10-13 10:13 PDT by Alex Christensen
Modified: 2017-10-16 16:30 PDT (History)
3 users (show)

See Also:

Patch (2.43 KB, patch)
2017-10-13 10:14 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (2.85 KB, patch)
2017-10-16 12:52 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2017-10-13 10:13:57 PDT
Allow modern decoding of URLs
Comment 1 Alex Christensen 2017-10-13 10:14:22 PDT
Created attachment 323690 [details]
Comment 2 Chris Dumez 2017-10-16 12:27:16 PDT
Comment on attachment 323690 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=323690&action=review

r=me with suggestion.

> Source/WebCore/platform/URL.h:299
> +std::optional<URL> URL::decode(Decoder& decoder)

When you do this sort of things, could we rewrite the legacy decoder to use the modern one to avoid duplication?

template <class Decoder>
bool URL::decode(Decoder& decoder, URL& url)
    auto optionalURL = URL::decode(decoder);
    if (!optionalURL)
        return false;
    url = optionalURL.value();
    return true;
Comment 3 Alex Christensen 2017-10-16 12:52:36 PDT
Created attachment 323929 [details]
Comment 4 WebKit Commit Bot 2017-10-16 16:29:40 PDT
Comment on attachment 323929 [details]

Clearing flags on attachment: 323929

Committed r223446: <https://trac.webkit.org/changeset/223446>
Comment 5 WebKit Commit Bot 2017-10-16 16:29:41 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-10-16 16:30:05 PDT