Bug 178260 - [css-grid] Avoid clearing the overrideContainingBlockWidth if possible
Summary: [css-grid] Avoid clearing the overrideContainingBlockWidth if possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-13 07:04 PDT by Javier Fernandez
Modified: 2017-11-15 13:05 PST (History)
8 users (show)

See Also:


Attachments
Patch (10.59 KB, patch)
2017-10-13 07:19 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Patch (10.60 KB, patch)
2017-10-16 03:19 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Patch (10.61 KB, patch)
2017-10-25 09:03 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2017-10-13 07:04:24 PDT
We are clearing/update the overrideContainingBLockWidth in some cases that is not necessary; in some cases we do it due orthogonal flows logic needs. 
I think this unneeded clear/updates operations may lead to unexpected behaviors when computing intrinsic size, so we must avoid it when possible.
Comment 1 Javier Fernandez 2017-10-13 07:19:33 PDT
Created attachment 323667 [details]
Patch
Comment 2 Javier Fernandez 2017-10-16 03:19:37 PDT
Created attachment 323881 [details]
Patch
Comment 3 Sergio Villar Senin 2017-10-25 08:47:09 PDT
Comment on attachment 323881 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323881&action=review

> Source/WebCore/ChangeLog:17
> +        This changes is a defensive approach to avoid the issues caused by

Nit: change
Comment 4 Javier Fernandez 2017-10-25 09:03:05 PDT
Created attachment 324829 [details]
Patch
Comment 5 WebKit Commit Bot 2017-10-25 09:38:18 PDT
Comment on attachment 324829 [details]
Patch

Clearing flags on attachment: 324829

Committed r223955: <https://trac.webkit.org/changeset/223955>
Comment 6 WebKit Commit Bot 2017-10-25 09:38:19 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-11-15 13:05:45 PST
<rdar://problem/35568771>