Bug 178217 - Mark more InlineBox member functions as const
Summary: Mark more InlineBox member functions as const
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-12 10:13 PDT by Daniel Bates
Modified: 2017-10-12 15:07 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2017-10-12 10:15 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2017-10-12 10:13:16 PDT 
Mark more InlineBox member functions as const
Comment 1 Daniel Bates 2017-10-12 10:15:48 PDT 
Created attachment 323533 [details]
Patch
Comment 2 Daniel Bates 2017-10-12 14:36:53 PDT 
Comment on attachment 323533 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323533&action=review

> Source/WebCore/rendering/InlineBox.cpp:295
>      RenderBlockFlow& block = root().blockFlow();

We should add a const version of RootInlineBox::blockFlow() or have it always return a const RenderBlockFlow&. Will fix in a follow up bug/patch.
Comment 3 Daniel Bates 2017-10-12 14:38:08 PDT 
Comment on attachment 323533 [details]
Patch

Clearing flags on attachment: 323533

Committed r223260: <https://trac.webkit.org/changeset/223260>
Comment 4 Daniel Bates 2017-10-12 14:38:09 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-10-12 14:38:46 PDT 
<rdar://problem/34964190>
Comment 6 Daniel Bates 2017-10-12 15:07:00 PDT 
(In reply to Daniel Bates from comment #2)
> Comment on attachment 323533 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323533&action=review
> 
> > Source/WebCore/rendering/InlineBox.cpp:295
> >      RenderBlockFlow& block = root().blockFlow();
> 
> We should add a const version of RootInlineBox::blockFlow() or have it
> always return a const RenderBlockFlow&. Will fix in a follow up bug/patch.

Actually, we should think about whether this makes sense to do in the context of the render tree. Deferring for now.