DataTransfer.cpp triggers -Wunused-but-set-variable

[Tomas Popela]

../../Source/WebCore/dom/DataTransfer.cpp: In member function ‘WTF::Vector<WTF::Ref<WebCore::File> > WebCore::DataTransfer::filesFromPasteboardAndItemList() const’:
../../Source/WebCore/dom/DataTransfer.cpp:289:10: warning: variable ‘addedFilesFromPasteboard’ set but not used [-Wunused-but-set-variable]
     bool addedFilesFromPasteboard = false;
          ^~~~~~~~~~~~~~~~~~~~~~~~
../../Source/WebCore/dom/DataTransfer.cpp:298:10: warning: variable ‘itemListContainsItems’ set but not used [-Wunused-but-set-variable]
     bool itemListContainsItems = false;
          ^~~~~~~~~~~~~~~~~~~~~

[Tomas Popela]

Created attachment 323523 [details]
Patch

[Alex Christensen]

Comment on attachment 323523 [details]
Patch

We could also solve this with ASSERT_DISABLED or ASSERT_UNUSED

[Tomas Popela]

(In reply to Alex Christensen from comment #2)
> Comment on attachment 323523 [details]
> Patch
> 
> We could also solve this with ASSERT_DISABLED or ASSERT_UNUSED

I knew there was a better way.. ASSERT_UNUSED is more cleaner solution.

[Tomas Popela]

Created attachment 323643 [details]
Patch

[Wenson Hsieh]

Comment on attachment 323643 [details]
Patch

I don't think processedFiles is a great name for this local variable...perhaps make this something like:

bool containsItemsAndFiles = itemListContainsItems && addedFilesFromPasteboard;

...and then ASSERT_UNUSED(containsItemsAndFiles, !containsItemsAndFiles);?

[Tomas Popela]

Committed r223334: <https://trac.webkit.org/changeset/223334>

[Radar WebKit Bug Importer]

<rdar://problem/35001133>