Bug 178178 – [GLib] WebKitNavigationAction should tell whether it is a redirect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Gustavo Noronha (kov)]

[GLib] WebKitNavigationAction should tell whether it is a redirect

[Gustavo Noronha (kov)]

Created attachment 323435 [details]
Patch

[Build Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Michael Catanzaro]

Comment on attachment 323435 [details]
Patch

LGTM. Carlos Garcia will surely want to do the final review, since it's new API.

[Adrian Perez]

Comment on attachment 323435 [details]
Patch

Same opinion as Michael: Looks good to me, but I am not
a reviewer yet so let's wait for Carlos to take a look.

[Carlos Garcia Campos]

Comment on attachment 323435 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323435&action=review

LGTM, thanks!

> Source/WebKit/UIProcess/API/glib/WebKitNavigationAction.cpp:158
> + * Return whether the navigation had a redirect.

@navigation I'm confused here about the use of "had".

> Source/WebKit/UIProcess/API/glib/WebKitNavigationAction.cpp:160
> + * Returns: whether the original navigation was redirected.

for boolean functions we normally use the pattern %TRUE if bla bla bla, or %FALSE otherwise.

[Gustavo Noronha (kov)]

Committed r223282: <https://trac.webkit.org/changeset/223282>

[Michael Catanzaro]

(In reply to Carlos Garcia Campos from comment #5)
> for boolean functions we normally use the pattern %TRUE if bla bla bla, or
> %FALSE otherwise.

Personally, I omit the "or %FALSE otherwise" because it's obvious.