Bug 178172 - Re-sync XMLHttpRequests Web-Platform-Tests
Summary: Re-sync XMLHttpRequests Web-Platform-Tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 168724
  Show dependency treegraph
 
Reported: 2017-10-11 10:02 PDT by Chris Dumez
Modified: 2017-10-11 12:41 PDT (History)
9 users (show)

See Also:


Attachments
Patch (67.75 KB, patch)
2017-10-11 10:32 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (67.18 KB, patch)
2017-10-11 10:39 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (1.30 MB, application/zip)
2017-10-11 11:37 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews103 for mac-elcapitan (999.47 KB, application/zip)
2017-10-11 11:45 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (955.07 KB, application/zip)
2017-10-11 12:09 PDT, Build Bot
no flags Details
Patch (64.53 KB, patch)
2017-10-11 12:11 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-11 10:02:21 PDT
Re-sync XMLHttpRequests Web-Platform-Tests.
Comment 1 Chris Dumez 2017-10-11 10:32:50 PDT
Created attachment 323426 [details]
Patch
Comment 2 Chris Dumez 2017-10-11 10:39:18 PDT
Created attachment 323427 [details]
Patch
Comment 3 youenn fablet 2017-10-11 11:36:45 PDT
Comment on attachment 323427 [details]
Patch

Some tests should be fixed to be actually useful.
Use common/get-host-info.sub.js for that purpose.

View in context: https://bugs.webkit.org/attachment.cgi?id=323427&action=review

> LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/open-url-worker-origin.htm:20
> +        var worker = new Worker("resources/workerxhr-origin-referrer.js")

Can we fix /workerxhr-origin-referrer.js to not use www2?

> LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-after-setting-document-domain.htm:12
> +      var test_base_url = location.protocol+'//www2.'+location.host+"/XMLHttpRequest/resources/",

Test should be fixed upstream

> LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-basic-cors-not-enabled.htm:16
> +          urlstart = 'www1.'+location.host + location.pathname.replace(/\/[^\/]*$/, '/')

Test should be fixed upstreamed.

> LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-basic-cors.htm:16
> +          urlstart = 'www1.'+location.host + location.pathname.replace(/\/[^\/]*$/, '/')

Ditto.

> LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/send-authentication-basic-expected.txt:3
> +Note: this test will only work as expected once per browsing session. Restart browser to re-test.

Can it make things flaky?
Comment 4 Build Bot 2017-10-11 11:37:45 PDT
Comment on attachment 323427 [details]
Patch

Attachment 323427 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4825914

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/preserve-ua-header-on-redirect.htm
Comment 5 Build Bot 2017-10-11 11:37:46 PDT
Created attachment 323434 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-10-11 11:45:04 PDT
Comment on attachment 323427 [details]
Patch

Attachment 323427 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4826054

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/preserve-ua-header-on-redirect.htm
Comment 7 Build Bot 2017-10-11 11:45:06 PDT
Created attachment 323436 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-10-11 12:09:45 PDT
Comment on attachment 323427 [details]
Patch

Attachment 323427 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4826153

New failing tests:
imported/w3c/web-platform-tests/XMLHttpRequest/preserve-ua-header-on-redirect.htm
Comment 9 Build Bot 2017-10-11 12:09:46 PDT
Created attachment 323441 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6
Comment 10 Chris Dumez 2017-10-11 12:11:59 PDT
Created attachment 323442 [details]
Patch
Comment 11 WebKit Commit Bot 2017-10-11 12:40:35 PDT
Comment on attachment 323442 [details]
Patch

Clearing flags on attachment: 323442

Committed r223203: <https://trac.webkit.org/changeset/223203>
Comment 12 WebKit Commit Bot 2017-10-11 12:40:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 13 Radar WebKit Bug Importer 2017-10-11 12:41:23 PDT
<rdar://problem/34939253>