module instance will be shared by URL's uniqueness. But if one request fails to fetch module, the other one should retry to fetch modules. <script type="module" src="http://example.com/A.js" integrity="invalid integrity hash"></script> <script type="module" src="http://example.com/A.js" integrity="correct integrity hash"></script> In the above case, second one should succeed. This is a spec change from the last implemented one. https://html.spec.whatwg.org/#fetch-a-single-module-script
Created attachment 323893 [details] Patch
Created attachment 324219 [details] Patch
Comment on attachment 324219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324219&action=review r=me > Source/JavaScriptCore/builtins/ModuleLoaderPrototype.js:220 > +function requestSatisfy(entry, parameters, fetcher, visited) Should we just use a default parameter value for visited instead of providing new @Set at a few call sites?
Comment on attachment 324219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=324219&action=review >> Source/JavaScriptCore/builtins/ModuleLoaderPrototype.js:220 >> +function requestSatisfy(entry, parameters, fetcher, visited) > > Should we just use a default parameter value for visited instead of providing new @Set at a few call sites? Sounds nice!
Created attachment 326533 [details] Patch
This patch modifies the JS builtins code generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-builtins-generator-tests --reset-results`)
Comment on attachment 326533 [details] Patch Attachment 326533 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/5172775 Number of test failures exceeded the failure limit.
Created attachment 326539 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 326533 [details] Patch Attachment 326533 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/5172782 Number of test failures exceeded the failure limit.
Created attachment 326542 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 326533 [details] Patch Attachment 326533 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/5172789 Number of test failures exceeded the failure limit.
Created attachment 326543 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 326533 [details] Patch Attachment 326533 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/5172795 Number of test failures exceeded the failure limit.
Created attachment 326544 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.6
Hm, default parameters need to extend builtin generators to accept them. In the meantime, I do not use it in this patch.
Committed r224662: <https://trac.webkit.org/changeset/224662>
<rdar://problem/35562356>