Bug 178156 - Add a SW context process (where SW scripts will actually execute)
Summary: Add a SW context process (where SW scripts will actually execute)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-10 22:05 PDT by Brady Eidson
Modified: 2017-10-11 10:28 PDT (History)
5 users (show)

See Also:


Attachments
EWS run (45.37 KB, patch)
2017-10-10 22:10 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
EWS run (45.31 KB, patch)
2017-10-10 22:12 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
EWS run (48.42 KB, patch)
2017-10-10 22:57 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
PFR (55.33 KB, patch)
2017-10-10 23:32 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (57.20 KB, patch)
2017-10-11 09:45 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-10-10 22:05:59 PDT
Add a SW context process (where SW scripts will actually execute)
Comment 1 Brady Eidson 2017-10-10 22:10:59 PDT
Created attachment 323386 [details]
EWS run
Comment 2 Brady Eidson 2017-10-10 22:12:02 PDT
Created attachment 323387 [details]
EWS run
Comment 3 Brady Eidson 2017-10-10 22:57:55 PDT
Created attachment 323389 [details]
EWS run
Comment 4 Brady Eidson 2017-10-10 23:32:13 PDT
Created attachment 323392 [details]
PFR
Comment 5 Andy Estes 2017-10-11 09:25:40 PDT
Comment on attachment 323392 [details]
PFR

View in context: https://bugs.webkit.org/attachment.cgi?id=323392&action=review

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:86
> +    auto worker = m_server.createWorker(connection, m_registrationKey, m_currentJob->scriptURL, result.script, WorkerType::Classic);

Surprised the compiler doesn't complain about worker not being used.

> Source/WebCore/workers/service/server/SWServerRegistration.cpp:92
> +    UNUSED_PARAM(workerID);

You could also remove "workerID" from the function signature.

> Source/WebCore/workers/service/server/SWServerRegistration.h:83
> +    double m_lastUpdateTime { 0.0 };

No need for ".0"
Comment 6 Brady Eidson 2017-10-11 09:35:31 PDT
(In reply to Andy Estes from comment #5)
> Comment on attachment 323392 [details]
> PFR
> 
> > Source/WebCore/workers/service/server/SWServerRegistration.cpp:92
> > +    UNUSED_PARAM(workerID);
> 
> You could also remove "workerID" from the function signature.

Explicitly left it to make it super obvious what it is without having to hop to the header (will be used very soon)
Comment 7 Brady Eidson 2017-10-11 09:45:55 PDT
Created attachment 323423 [details]
Patch
Comment 8 WebKit Commit Bot 2017-10-11 10:27:12 PDT
Comment on attachment 323423 [details]
Patch

Clearing flags on attachment: 323423

Committed r223191: <https://trac.webkit.org/changeset/223191>
Comment 9 WebKit Commit Bot 2017-10-11 10:27:13 PDT
All reviewed patches have been landed.  Closing bug.
Comment 10 Radar WebKit Bug Importer 2017-10-11 10:28:13 PDT
<rdar://problem/34936051>