WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
178155
Remove out-parameter variants of copyToVector
https://bugs.webkit.org/show_bug.cgi?id=178155
Summary
Remove out-parameter variants of copyToVector
Sam Weinig
Reported
2017-10-10 21:35:40 PDT
Remove out-parameter variants of copyToVector
Attachments
Patch
(59.57 KB, patch)
2017-10-11 05:26 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(58.84 KB, patch)
2017-10-11 07:52 PDT
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(60.10 KB, patch)
2017-10-11 10:20 PDT
,
Sam Weinig
thorton
: review+
commit-queue
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2017-10-11 05:26:56 PDT
Created
attachment 323412
[details]
Patch
Sam Weinig
Comment 2
2017-10-11 07:52:08 PDT
Created
attachment 323416
[details]
Patch
Sam Weinig
Comment 3
2017-10-11 10:20:20 PDT
Created
attachment 323425
[details]
Patch
WebKit Commit Bot
Comment 4
2017-10-11 11:52:24 PDT
Comment on
attachment 323425
[details]
Patch Rejecting
attachment 323425
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 323425, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/Plugins/WebNetscapePluginView.mm patching file Source/WebKitLegacy/mac/WebView/WebHTMLRepresentation.mm patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/JavaScriptThreading.cpp Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Tim Horton']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.webkit.org/results/4826419
Sam Weinig
Comment 5
2017-10-12 08:38:45 PDT
Committed
r223238
: <
https://trac.webkit.org/changeset/223238
>
Radar WebKit Bug Importer
Comment 6
2017-10-12 08:39:34 PDT
<
rdar://problem/34955906
>
Chris Dumez
Comment 7
2017-10-12 10:11:15 PDT
Broke internal build.
Chris Dumez
Comment 8
2017-10-12 10:40:12 PDT
(In reply to Chris Dumez from
comment #7
)
> Broke internal build.
I may have fixed it.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug