RESOLVED FIXED 178153
Web Inspector: Open Resource Dialog should show path to resource (to disambiguate resources with same name) 
https://bugs.webkit.org/show_bug.cgi?id=178153
Summary Web Inspector: Open Resource Dialog should show path to resource (to disambig...
Blaze Burg
Reported 2017-10-10 19:33:16 PDT
Created attachment 323370 [details] Xcode 9 UI If a page has 20 index.js pages due to source maps, you can't tell which is which. We should show the folderized path below the main resource name.
Attachments
Xcode 9 UI (106.32 KB, image/png)
2017-10-10 19:33 PDT, Blaze Burg 		no flags
Details
TOT Inspector UI (106.91 KB, image/png)
2017-10-10 19:33 PDT, Blaze Burg 		no flags
Details
Patch (3.47 KB, patch)
2018-10-03 22:50 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (181.65 KB, image/png)
2018-10-03 22:50 PDT, Devin Rousso 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Blaze Burg
Comment 1 2017-10-10 19:33:47 PDT
Created attachment 323371 [details] TOT Inspector UI
Radar WebKit Bug Importer
Comment 2 2017-10-10 19:34:27 PDT
<rdar://problem/34925686>
Devin Rousso
Comment 3 2018-10-03 22:50:00 PDT
Created attachment 351586 [details] Patch My attempt at using pure-ish CSS to get the desired effect. The main issue is that since everything is `display: inline;`, it's hard to position things properly.
Devin Rousso
Comment 4 2018-10-03 22:50:26 PDT
Created attachment 351587 [details] [Image] After Patch is applied
Blaze Burg
Comment 5 2018-10-08 09:26:24 PDT
Comment on attachment 351586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=351586&action=review r=me > Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:181 > +.open-resource-dialog .tree-outline.large .item .titles[data-path]::after { Clever! I have never used Element.dataset.
WebKit Commit Bot
Comment 6 2018-10-08 10:15:28 PDT
Comment on attachment 351586 [details] Patch Clearing flags on attachment: 351586 Committed r236918: <https://trac.webkit.org/changeset/236918>
WebKit Commit Bot
Comment 7 2018-10-08 10:15:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.