RESOLVED FIXED 178152
Web Inspector: Open Resource dialog should support matching file paths 
https://bugs.webkit.org/show_bug.cgi?id=178152
Summary Web Inspector: Open Resource dialog should support matching file paths
Blaze Burg
Reported 2017-10-10 19:31:04 PDT
When using Quick Open in Inspector^2, "Models/Action" should match Models/BreakpointAction.js. This could match based on the URL, which should match up with displayed path based on resource folderization. Currently, it won't match anything if you type that string.
Attachments
Patch (24.77 KB, patch)
2019-03-01 15:03 PST, Devin Rousso 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-10 19:32:28 PDT
<rdar://problem/34925656>
Devin Rousso
Comment 2 2019-03-01 15:03:04 PST
Created attachment 363380 [details] Patch An extremely naive approach that I did very quickly that somewhat works :(
Joseph Pecoraro
Comment 3 2019-10-14 12:28:55 PDT
This is reviewed, should it land?
Devin Rousso
Comment 4 2019-10-14 12:34:46 PDT
(In reply to Joseph Pecoraro from comment #3) > This is reviewed, should it land? I don't think I'd intended this for landing (or review, but `webkit-patch upload` defaults to r?), so probably not. This was an _extremely_ naive approach of just "well try searching against the URL too, in addition to the name" and isn't very smart. I vaguely remember there being some odd edge cases where the functionality got a bit funky, but I can't recall what exactly.
Devin Rousso
Comment 5 2022-05-27 20:15:29 PDT
Pull request: https://github.com/WebKit/WebKit/pull/1136
EWS
Comment 6 2022-05-31 11:10:16 PDT
Committed r295060 (251155@main): <https://commits.webkit.org/251155@main> Reviewed commits have been landed. Closing PR #1136 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.