Bug 178150 - [Payment Request] Validate that all PaymentCurrencyAmounts use the same currency code when using Apple Pay
Summary: [Payment Request] Validate that all PaymentCurrencyAmounts use the same curre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks: 174796
  Show dependency tree / graph
 
Reported: 2017-10-10 17:55 PDT by Andy Estes
Modified: 2017-10-11 09:12 PDT (History)
13 users (show)

See Also:

Attachments
Patch (24.46 KB, patch)
2017-10-10 17:59 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-10-10 17:55:25 PDT 
[Payment Request] Validate that all PaymentCurrencyAmounts use the same currency code when using Apple Pay
Comment 1 Andy Estes 2017-10-10 17:59:42 PDT 
Created attachment 323366 [details]
Patch
Comment 2 WebKit Commit Bot 2017-10-10 19:57:16 PDT 
Comment on attachment 323366 [details]
Patch

Clearing flags on attachment: 323366

Committed r223163: <http://trac.webkit.org/changeset/223163>
Comment 3 WebKit Commit Bot 2017-10-10 19:57:17 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-10-10 19:58:35 PDT 
<rdar://problem/34925906>
Comment 5 Ryan Haddad 2017-10-11 08:54:56 PDT 
This change broke the Sierra build:

(view as text)
/Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:87:12: error: no viable conversion from returned value of type 'ApplePaySessionPaymentRequest::LineItem' to function return type 'ExceptionOr<ApplePaySessionPaymentRequest::LineItem>'
/Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:100:12: error: no viable conversion from returned value of type 'Vector<ApplePaySessionPaymentRequest::LineItem>' to function return type 'ExceptionOr<Vector<ApplePaySessionPaymentRequest::LineItem> >'
/Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:138:12: error: no viable conversion from returned value of type 'ApplePaySessionPaymentRequest::ShippingMethod' to function return type 'ExceptionOr<ApplePaySessionPaymentRequest::ShippingMethod>'

https://build.webkit.org/builders/Apple%20Sierra%20Release%20%28Build%29/builds/5606
Comment 6 Andy Estes 2017-10-11 09:12:45 PDT 
(In reply to Ryan Haddad from comment #5)
> This change broke the Sierra build:
> 
> (view as text)
> /Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/
> paymentrequest/ApplePayPaymentHandler.cpp:87:12: error: no viable conversion
> from returned value of type 'ApplePaySessionPaymentRequest::LineItem' to
> function return type 'ExceptionOr<ApplePaySessionPaymentRequest::LineItem>'
> /Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/
> paymentrequest/ApplePayPaymentHandler.cpp:100:12: error: no viable
> conversion from returned value of type
> 'Vector<ApplePaySessionPaymentRequest::LineItem>' to function return type
> 'ExceptionOr<Vector<ApplePaySessionPaymentRequest::LineItem> >'
> /Volumes/Data/slave/sierra-release/build/Source/WebCore/Modules/applepay/
> paymentrequest/ApplePayPaymentHandler.cpp:138:12: error: no viable
> conversion from returned value of type
> 'ApplePaySessionPaymentRequest::ShippingMethod' to function return type
> 'ExceptionOr<ApplePaySessionPaymentRequest::ShippingMethod>'
> 
> https://build.webkit.org/builders/Apple%20Sierra%20Release%20%28Build%29/
> builds/5606

Tried to fix in r223188: <https://trac.webkit.org/changeset/223188>