Bug 178144 – AccessibilityRenderObject should not hold a raw pointer to RenderObject

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[alan]

the m_renderer's lifetime is not controlled by the AX object.

[Radar WebKit Bug Importer]

<rdar://problem/34919287>

[alan]

Created attachment 323350 [details]
Patch

[chris fleizach]

Comment on attachment 323350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323350&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.h:220
> +    WeakPtr<RenderObject> m_renderer;

can we move this to private, so fewer clients will be tempted to use it directly

[alan]

(In reply to chris fleizach from comment #3)
> Comment on attachment 323350 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323350&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.h:220
> > +    WeakPtr<RenderObject> m_renderer;
> 
> can we move this to private, so fewer clients will be tempted to use it
> directly
Sure! Good idea.

[alan]

(In reply to zalan from comment #4)
> (In reply to chris fleizach from comment #3)
> > Comment on attachment 323350 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=323350&action=review
> > 
> > > Source/WebCore/accessibility/AccessibilityRenderObject.h:220
> > > +    WeakPtr<RenderObject> m_renderer;
> > 
> > can we move this to private, so fewer clients will be tempted to use it
> > directly
> Sure! Good idea.
If you don't mind, I'd rather do that in a separate patch.

[WebKit Commit Bot]

Comment on attachment 323350 [details]
Patch

Clearing flags on attachment: 323350

Committed r223151: <http://trac.webkit.org/changeset/223151>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.