Bug 178144 - AccessibilityRenderObject should not hold a raw pointer to RenderObject
Summary: AccessibilityRenderObject should not hold a raw pointer to RenderObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-10 14:14 PDT by zalan
Modified: 2017-10-10 15:47 PDT (History)
11 users (show)

See Also:

Attachments
Patch (20.65 KB, patch)
2017-10-10 14:25 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2017-10-10 14:14:16 PDT 
the m_renderer's lifetime is not controlled by the AX object.
Comment 1 Radar WebKit Bug Importer 2017-10-10 14:14:32 PDT 
<rdar://problem/34919287>
Comment 2 zalan 2017-10-10 14:25:51 PDT 
Created attachment 323350 [details]
Patch
Comment 3 chris fleizach 2017-10-10 14:31:39 PDT 
Comment on attachment 323350 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323350&action=review

> Source/WebCore/accessibility/AccessibilityRenderObject.h:220
> +    WeakPtr<RenderObject> m_renderer;

can we move this to private, so fewer clients will be tempted to use it directly
Comment 4 zalan 2017-10-10 14:32:30 PDT 
(In reply to chris fleizach from comment #3)
> Comment on attachment 323350 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=323350&action=review
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.h:220
> > +    WeakPtr<RenderObject> m_renderer;
> 
> can we move this to private, so fewer clients will be tempted to use it
> directly
Sure! Good idea.
Comment 5 zalan 2017-10-10 15:09:28 PDT 
(In reply to zalan from comment #4)
> (In reply to chris fleizach from comment #3)
> > Comment on attachment 323350 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=323350&action=review
> > 
> > > Source/WebCore/accessibility/AccessibilityRenderObject.h:220
> > > +    WeakPtr<RenderObject> m_renderer;
> > 
> > can we move this to private, so fewer clients will be tempted to use it
> > directly
> Sure! Good idea.
If you don't mind, I'd rather do that in a separate patch.
Comment 6 WebKit Commit Bot 2017-10-10 15:47:34 PDT 
Comment on attachment 323350 [details]
Patch

Clearing flags on attachment: 323350

Committed r223151: <http://trac.webkit.org/changeset/223151>
Comment 7 WebKit Commit Bot 2017-10-10 15:47:35 PDT 
All reviewed patches have been landed.  Closing bug.