Bug 178143 - Web Inspector: Avoid "100.00ms" vs "100.0ms" jitter in TimelineRuler labels
Summary: Web Inspector: Avoid "100.00ms" vs "100.0ms" jitter in TimelineRuler labels
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-10 13:49 PDT by Joseph Pecoraro
Modified: 2017-10-11 01:01 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (2.05 KB, patch)
2017-10-10 13:50 PDT, Joseph Pecoraro 		bburg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-10-10 13:49:12 PDT 
Avoid "100.00ms" vs "100.0ms" jitter in TimelineRuler labels

Sometimes the ms calculated ends up being values like:

    100.0             => "100.0ms"
    100.0000000000001 => "100.00ms"

Account for this tiny jitter by checking against values like 100.0001.
Comment 1 Joseph Pecoraro 2017-10-10 13:50:39 PDT 
Created attachment 323346 [details]
[PATCH] Proposed Fix
Comment 2 BJ Burg 2017-10-10 14:09:46 PDT 
Comment on attachment 323346 [details]
[PATCH] Proposed Fix

r=me. Can you extract out the slop factor into a variable?
Comment 3 Joseph Pecoraro 2017-10-11 01:00:41 PDT 
<https://trac.webkit.org/changeset/223171/webkit>
Comment 4 Radar WebKit Bug Importer 2017-10-11 01:01:47 PDT 
<rdar://problem/34928802>