Bug 178140 - Respect audio rate change restrictions in HTMLMediaElement::setVolume
Summary: Respect audio rate change restrictions in HTMLMediaElement::setVolume
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Matt Rajca
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-10 12:41 PDT by Matt Rajca
Modified: 2017-10-10 14:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch (9.36 KB, patch)
2017-10-10 13:00 PDT, Matt Rajca 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Rajca 2017-10-10 12:41:34 PDT 
If a non-zero volume is set and there are audio rate change restrictions, we should pause the media element just like we do in mediaPlayerDidAddAudioTrack for media that started off silent.
Comment 1 Matt Rajca 2017-10-10 13:00:10 PDT 
Created attachment 323333 [details]
Patch
Comment 2 Matt Rajca 2017-10-10 13:57:51 PDT 
<rdar://problem/34740746>
Comment 3 Matt Rajca 2017-10-10 14:26:13 PDT 
Committed r223144: <http://trac.webkit.org/changeset/223144>