RESOLVED FIXED 178139
Layers should be destroyed by RenderLayerModelObject 
https://bugs.webkit.org/show_bug.cgi?id=178139
Summary Layers should be destroyed by RenderLayerModelObject
Antti Koivisto
Reported 2017-10-10 11:51:41 PDT
...instead of RenderObject.
Attachments
patch (3.09 KB, patch)
2017-10-10 11:52 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-10-10 11:52:55 PDT
Created attachment 323328 [details] patch
Simon Fraser (smfr)
Comment 2 2017-10-10 12:53:09 PDT
Comment on attachment 323328 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=323328&action=review > Source/WebCore/rendering/RenderObject.cpp:-1444 > - // FIXME: Would like to do this in RenderBoxModelObject, but the timing is so complicated that this can't easily > - // be moved into RenderLayerModelObject::willBeDestroyed(). > - // FIXME: Is this still true? > - if (hasLayer()) { > - setHasLayer(false); > - downcast<RenderLayerModelObject>(*this).destroyLayer(); > - } > - Should RenderObject have ASSERT(!hasLayer()) somewhere late in its destruction to ensure that we didn't re-assign a layer after RenderLayerModelObject::destroyLayer() ran?
Antti Koivisto
Comment 3 2017-10-10 13:09:41 PDT
There isn't really much between willBeDestroyed() and the destructor.
WebKit Commit Bot
Comment 4 2017-10-10 13:36:51 PDT
Comment on attachment 323328 [details] patch Clearing flags on attachment: 323328 Committed r223139: <http://trac.webkit.org/changeset/223139>
WebKit Commit Bot
Comment 5 2017-10-10 13:36:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-10-10 13:37:54 PDT
<rdar://problem/34918241>
Note You need to log in before you can comment on or make changes to this bug.