Layers should be destroyed by RenderLayerModelObject

[Antti Koivisto]

...instead of RenderObject.

[Antti Koivisto]

Created attachment 323328 [details]
patch

[Simon Fraser (smfr)]

Comment on attachment 323328 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323328&action=review

> Source/WebCore/rendering/RenderObject.cpp:-1444
> -    // FIXME: Would like to do this in RenderBoxModelObject, but the timing is so complicated that this can't easily
> -    // be moved into RenderLayerModelObject::willBeDestroyed().
> -    // FIXME: Is this still true?
> -    if (hasLayer()) {
> -        setHasLayer(false);
> -        downcast<RenderLayerModelObject>(*this).destroyLayer();
> -    }
> -

Should RenderObject have ASSERT(!hasLayer()) somewhere late in its destruction to ensure that we didn't re-assign a layer after RenderLayerModelObject::destroyLayer() ran?

[Antti Koivisto]

There isn't really much between willBeDestroyed() and the destructor.

[WebKit Commit Bot]

Comment on attachment 323328 [details]
patch

Clearing flags on attachment: 323328

Committed r223139: <http://trac.webkit.org/changeset/223139>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/34918241>