Bug 178132 - Bump default cache storage quota to 20MB
Summary: Bump default cache storage quota to 20MB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-10 08:49 PDT by youenn fablet
Modified: 2017-10-11 13:42 PDT (History)
3 users (show)

See Also:

Attachments
Patch (13.72 KB, patch)
2017-10-10 10:08 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (13.73 KB, patch)
2017-10-10 10:36 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (28.07 KB, patch)
2017-10-10 16:57 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (28.71 KB, patch)
2017-10-10 17:01 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2017-10-10 08:49:15 PDT 
Bump default cache storage quota to 20MB
Comment 1 youenn fablet 2017-10-10 10:08:22 PDT 
Created attachment 323313 [details]
Patch
Comment 2 youenn fablet 2017-10-10 10:36:13 PDT 
Created attachment 323317 [details]
Patch
Comment 3 Alex Christensen 2017-10-10 13:02:17 PDT 
Comment on attachment 323317 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323317&action=review

> Source/WebKit/NetworkProcess/NetworkProcess.cpp:774
> +void NetworkProcess::setCacheStoragePerOriginQuota(uint64_t quota)

This shouldn't be here.

> Source/WebKit/NetworkProcess/NetworkProcess.h:149
>      uint64_t cacheStoragePerOriginQuota() const;
> +    void setCacheStoragePerOriginQuota(uint64_t);

These should both be removed and replaced by values on WebsiteDataStore.

> Source/WebKit/UIProcess/API/APIProcessPoolConfiguration.h:157
> +    uint64_t m_cacheStoragePerOriginQuota { WebKit::WebsiteDataStore::defaultCacheStoragePerOriginQuota };

This should be completely removed.

> Source/WebKit/UIProcess/WebsiteData/WebsiteDataStore.h:187
> +    unsigned m_cacheStoragePerOriginQuota { defaultCacheStoragePerOriginQuota };

uint64_t
Comment 4 youenn fablet 2017-10-10 16:57:00 PDT 
Created attachment 323361 [details]
Patch
Comment 5 youenn fablet 2017-10-10 17:01:58 PDT 
Created attachment 323363 [details]
Patch
Comment 6 WebKit Commit Bot 2017-10-11 13:41:03 PDT 
Comment on attachment 323363 [details]
Patch

Clearing flags on attachment: 323363

Committed r223207: <https://trac.webkit.org/changeset/223207>
Comment 7 WebKit Commit Bot 2017-10-11 13:41:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-10-11 13:42:19 PDT 
<rdar://problem/34940657>