Bug 178125 - [WPE] Remove the possibility of installing the old WebKit2 C API
Summary: [WPE] Remove the possibility of installing the old WebKit2 C API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords:
Depends on: 176475 178100 178104
Blocks:
  Show dependency tree / graph
 
Reported: 2017-10-10 04:26 PDT by Adrian Perez
Modified: 2017-10-10 18:02 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.86 KB, patch)
2017-10-10 16:03 PDT, Adrian Perez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2017-10-10 04:26:45 PDT 
We have the new GLib-based API, and we really don't want to maintain
two different sets of public API.
Comment 1 Adrian Perez 2017-10-10 04:30:46 PDT 
Updated dependency bugs. This shouldn't be removed until we ensure
that the new GLib WPE API is usable.
Comment 2 Michael Catanzaro 2017-10-10 04:45:51 PDT 
You can remove it now if you want; I'll be doing so at first opportunity in any case. We agreed that removing the C API and ensuring the GLib API works are both blockers for the first release and it doesn't matter which order that happens in.
Comment 3 Carlos Alberto Lopez Perez 2017-10-10 12:20:17 PDT 
IIRC WPEWebKitLauncher doesn't build anymore with current trunk (even when enabling the deprecated headers).

dyz is works fine for me as a replacement for WPEWebKitLauncher.
Comment 4 Adrian Perez 2017-10-10 13:22:37 PDT 
First I am going to take care of the rest of bugs which are
preventing usage of the new GLib-based API, and then I will
post the patch for this one ;-)

Thanks for the comments supporting the removal — I was aware
of the agreement, but I wanted to make sure it would not go
completely unannounced.
Comment 5 Adrian Perez 2017-10-10 16:03:34 PDT 
Created attachment 323357 [details]
Patch
Comment 6 WebKit Commit Bot 2017-10-10 18:01:57 PDT 
Comment on attachment 323357 [details]
Patch

Clearing flags on attachment: 323357

Committed r223162: <http://trac.webkit.org/changeset/223162>
Comment 7 WebKit Commit Bot 2017-10-10 18:01:58 PDT 
All reviewed patches have been landed.  Closing bug.