Bug 178114 - Calling fileSystemDirectoryEntry.getDirectory() with empty path should not fail
Summary: Calling fileSystemDirectoryEntry.getDirectory() with empty path should not fail
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: http://w3c-test.org/entries-api/files...
Keywords: InRadar, WebExposed
Depends on:
Blocks:
 
Reported: 2017-10-09 19:54 PDT by Chris Dumez
Modified: 2017-10-09 21:10 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.83 KB, patch)
2017-10-09 19:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-10-09 19:54:12 PDT 
Calling fileSystemDirectoryEntry.getDirectory() with empty/null/undefined path should not fail as per:
- https://wicg.github.io/entries-api/#dom-filesystemdirectoryentry-getdirectory

The empty string is a valid path as per:
- https://wicg.github.io/entries-api/#valid-path

This aligns out behavior with Chrome.

Test: http://w3c-test.org/entries-api/filesystemdirectoryentry-getDirectory-manual.html
Comment 1 Chris Dumez 2017-10-09 19:56:17 PDT 
Created attachment 323272 [details]
Patch
Comment 2 Ryosuke Niwa 2017-10-09 20:27:28 PDT 
Comment on attachment 323272 [details]
Patch

r=me preemptively
Comment 3 WebKit Commit Bot 2017-10-09 21:10:06 PDT 
Comment on attachment 323272 [details]
Patch

Clearing flags on attachment: 323272

Committed r223118: <http://trac.webkit.org/changeset/223118>
Comment 4 WebKit Commit Bot 2017-10-09 21:10:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2017-10-09 21:10:38 PDT 
<rdar://problem/34902704>