WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
178106
Update JavaScriptCore/ucd/CaseFolding.txt to Unicode database 10.0
https://bugs.webkit.org/show_bug.cgi?id=178106
Summary
Update JavaScriptCore/ucd/CaseFolding.txt to Unicode database 10.0
Michael Saboff
Reported
2017-10-09 18:02:28 PDT
Change set
r223081
added new Unicode database (UCD) data files to the source tree. The version of the added files is UCD 10.0. The UCD file checked in version of Source/JavaScriptCore/CaseFolding.txt is 8.0. CaseFolding.txt should be updated to 10.0 as well. This may require updating some tests.
Attachments
Patch
(6.61 KB, patch)
2017-10-11 10:54 PDT
,
Michael Saboff
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-10-09 18:04:33 PDT
<
rdar://problem/34900035
>
Michael Saboff
Comment 2
2017-10-11 10:54:17 PDT
Created
attachment 323429
[details]
Patch
Alexey Proskuryakov
Comment 3
2017-10-11 11:09:39 PDT
Comment on
attachment 323429
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=323429&action=review
> Source/JavaScriptCore/ChangeLog:3 > + Update JavaScriptCore/ucd/CaseFolding.txt to Unicode database 10.0
Can this be tested at all?
Michael Saboff
Comment 4
2017-10-11 11:43:22 PDT
(In reply to Alexey Proskuryakov from
comment #3
)
> Comment on
attachment 323429
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=323429&action=review
> > > Source/JavaScriptCore/ChangeLog:3 > > + Update JavaScriptCore/ucd/CaseFolding.txt to Unicode database 10.0 > > Can this be tested at all?
We can add new tests for the new case folding rules. Since the code is data driven and we have tests that cover the transformation, I didn't add any for the new rules.
Keith Miller
Comment 5
2017-10-11 11:46:24 PDT
Comment on
attachment 323429
[details]
Patch rs=me.
WebKit Commit Bot
Comment 6
2017-10-11 12:14:02 PDT
Comment on
attachment 323429
[details]
Patch Clearing flags on attachment: 323429 Committed
r223197
: <
https://trac.webkit.org/changeset/223197
>
WebKit Commit Bot
Comment 7
2017-10-11 12:14:04 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug