Network Tab - Show initially loaded resources even if network info not logged When just opening Web Inspector it is often weird that the Network table is empty when the page has some resources. Lets try including all of the page resources in the Table even though they don't have networking data.
<rdar://problem/34073529>
Created attachment 323234 [details] [IMAGE] Table - Inspector Was Open + Reload
Created attachment 323235 [details] [IMAGE] Table - Inspector Just Opened
Created attachment 323236 [details] [PATCH] Proposed Fix
Comment on attachment 323236 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=323236&action=review r=me. Would like to see another patch tho, specifically for the ChangeLog fixes. > Source/WebInspectorUI/ChangeLog:12 > + So treat hasResposne Oops. :P > Source/WebInspectorUI/ChangeLog:23 > + While this path is not taken pre-table, change this so that if it is > + that the resouce is not lost and is instead a pending insertion. "so that if it is that" is a bit awkward :/ > Source/WebInspectorUI/UserInterface/Models/Resource.js:656 > + return !isNaN(this._statusCode) || this._finished; Will this cause problems with WI.ResourceHeadersContentView (or WI.ResourceTimelineDataGridNode)? > Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:105 > + WI.frameResourceManager.addEventListener(WI.FrameResourceManager.Event.MainFrameDidChange, this._mainFrameDidChange, this); Can we move this to an `initialLayout()`? The other event listeners too?
Comment on attachment 323236 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=323236&action=review >> Source/WebInspectorUI/UserInterface/Models/Resource.js:656 >> + return !isNaN(this._statusCode) || this._finished; > > Will this cause problems with WI.ResourceHeadersContentView (or WI.ResourceTimelineDataGridNode)? They have been updated. >> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:105 >> + WI.frameResourceManager.addEventListener(WI.FrameResourceManager.Event.MainFrameDidChange, this._mainFrameDidChange, this); > > Can we move this to an `initialLayout()`? The other event listeners too? That would be too late.
<https://trac.webkit.org/changeset/223170/webkit>