Bug 178096 – Delete button doesn't fully delete certain emoji

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Delete button doesn't fully delete certain emoji

[Myles C. Maxfield]

Created attachment 323223 [details]
Patch

[Myles C. Maxfield]

Created attachment 323224 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/34785106>

[Myles C. Maxfield]

Created attachment 323232 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 323232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323232&action=review

> Source/WebCore/ChangeLog:11
> +        System infrastructure for handling emoji changes every year. Instead of having
> +        custom code to specifically walk over codepoints, we should delegate to the
> +        system handling.

Can we do this on all systems that we support?

[Myles C. Maxfield]

Comment on attachment 323232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323232&action=review

>> Source/WebCore/ChangeLog:11
>> +        system handling.
> 
> Can we do this on all systems that we support?

Yep, it falls back to ICU on non-cocoa platforms (and all ports support ICU)

[Darin Adler]

Comment on attachment 323232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323232&action=review

> Source/WebCore/rendering/RenderText.cpp:1533
> +    CachedTextBreakIterator iterator(StringView(m_text), TextBreakIterator::Mode::Caret, nullAtom());

Do we need to explicitly cast to StringView?

[Myles C. Maxfield]

Comment on attachment 323232 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323232&action=review

>> Source/WebCore/rendering/RenderText.cpp:1533
>> +    CachedTextBreakIterator iterator(StringView(m_text), TextBreakIterator::Mode::Caret, nullAtom());
> 
> Do we need to explicitly cast to StringView?

Nope! 😎

[Build Bot]

Comment on attachment 323232 [details]
Patch

Attachment 323232 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4805921

New failing tests:
editing/deleting/delete-emoji-2.html
editing/deleting/delete-emoji.html

[Build Bot]

Created attachment 323256 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Myles C. Maxfield]

Committed r223110: <http://trac.webkit.org/changeset/223110>

[Matt Lewis]

This revision caused the test editing/deleting/delete-emoji.html to start failing consistently on macOS Sierra and timeout consistently on macOS El Capitan:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=editing%2Fdeleting%2Fdelete-emoji.html

Fail:
https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/4930

Timeout:
https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/3555

[Matt Lewis]

Created attachment 323315 [details]
Failed Diff

This is the diff for the failure on Sierra WK2 Release.

If this cant be resolved soon, I'd like to revert the change as it will begin causing problems in EWS.

[Matt Lewis]

Reverted r223110 for reason:

This caused consistent failures and timeouts on multiple platforms.

Committed r223134: <http://trac.webkit.org/changeset/223134>

[Myles C. Maxfield]

Created attachment 323340 [details]
WIP

[Myles C. Maxfield]

Created attachment 323475 [details]
test

[Myles C. Maxfield]

Created attachment 323484 [details]
WIP

[Myles C. Maxfield]

Created attachment 323563 [details]
WIP

[Myles C. Maxfield]

Created attachment 323590 [details]
New expected results

[Build Bot]

Comment on attachment 323590 [details]
New expected results

Attachment 323590 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4838962

New failing tests:
editing/deleting/delete-emoji-3.html
editing/deleting/delete-emoji-2.html
editing/deleting/delete-emoji.html

[Build Bot]

Created attachment 323613 [details]
Archive of layout-test-results from ews115 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323590 [details]
New expected results

Attachment 323590 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4839860

New failing tests:
editing/deleting/delete-emoji-3.html
editing/deleting/delete-emoji-2.html
editing/deleting/delete-emoji.html

[Build Bot]

Created attachment 323621 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323590 [details]
New expected results

Attachment 323590 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4840059

New failing tests:
editing/deleting/delete-emoji-3.html
editing/deleting/delete-emoji-2.html
editing/deleting/delete-emoji.html

[Build Bot]

Created attachment 323622 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 323712 [details]
WIP

[Build Bot]

Comment on attachment 323712 [details]
WIP

Attachment 323712 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4849255

New failing tests:
editing/deleting/delete-emoji-9.html
editing/deleting/delete-emoji-8.html
editing/deleting/delete-emoji-6.html
editing/deleting/delete-emoji.html
editing/deleting/delete-emoji-4.html
editing/deleting/delete-emoji-2.html
editing/deleting/delete-emoji-3.html
editing/deleting/delete-emoji-5.html
editing/deleting/delete-emoji-7.html

[Build Bot]

Created attachment 323730 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323712 [details]
WIP

Attachment 323712 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4849535

New failing tests:
editing/deleting/delete-emoji-9.html
editing/deleting/delete-emoji-8.html
editing/deleting/delete-emoji-6.html
editing/deleting/delete-emoji.html
editing/deleting/delete-emoji-4.html
editing/deleting/delete-emoji-2.html
editing/deleting/delete-emoji-3.html
editing/deleting/delete-emoji-5.html
editing/deleting/delete-emoji-7.html

[Build Bot]

Created attachment 323735 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 323712 [details]
WIP

Attachment 323712 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4849432

New failing tests:
editing/deleting/delete-emoji-9.html
editing/deleting/delete-emoji-8.html
editing/deleting/delete-emoji-6.html
editing/deleting/delete-emoji.html
editing/deleting/delete-emoji-4.html
editing/deleting/delete-emoji-2.html
editing/deleting/delete-emoji-3.html
editing/deleting/delete-emoji-5.html
editing/deleting/delete-emoji-7.html

[Build Bot]

Created attachment 323737 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 323743 [details]
WIP

[Myles C. Maxfield]

Created attachment 323750 [details]
Patch

[Build Bot]

Comment on attachment 323750 [details]
Patch

Attachment 323750 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4852668

New failing tests:
editing/deleting/delete-emoji-9.html

[Build Bot]

Created attachment 323783 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.6

[Myles C. Maxfield]

Created attachment 324042 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 324042 [details]
Patch for committing

Clearing flags on attachment: 324042

Committed r223578: <https://trac.webkit.org/changeset/223578>

[Ahmad Saleem]

Landed - https://github.com/WebKit/WebKit/commit/7ece327caf929743ca3eab0654c3fcaf8609e324

https://github.com/WebKit/WebKit/commit/28d78645e97862fb0b4bbafbc436c3a7a023e424

but seems to be backed-out:

https://github.com/WebKit/WebKit/commit/14819586c2767f05a240e49553ce084a843ba58a

Is this still required?