Bug 178084 - Add isContinuation bit
Summary: Add isContinuation bit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-10-09 09:49 PDT by Antti Koivisto
Modified: 2017-10-10 03:39 PDT (History)
6 users (show)

See Also:

Attachments
patch (11.45 KB, patch)
2017-10-09 09:59 PDT, Antti Koivisto 		zalan: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-elcapitan (1006.87 KB, application/zip)
2017-10-09 11:08 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.08 MB, application/zip)
2017-10-09 11:13 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.87 MB, application/zip)
2017-10-09 11:56 PDT, Build Bot 		no flags Details
patch (11.91 KB, patch)
2017-10-10 02:17 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2017-10-09 09:49:47 PDT 
Currently continuations are identified indirectly by comparing renderer pointer with the element renderer pointer. This is bug prone and fails to cover anonymous continuations.
Comment 1 Antti Koivisto 2017-10-09 09:59:24 PDT 
Created attachment 323180 [details]
patch
Comment 2 zalan 2017-10-09 10:07:30 PDT 
Comment on attachment 323180 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=323180&action=review

> Source/WebCore/rendering/RenderElement.h:229
> +    bool isBlockElementContinuation() const { return isElementContinuation() && !isInline(); }

Is it actually used at all? I can't find any callsites on this.
Comment 3 Antti Koivisto 2017-10-09 10:49:39 PDT 
> Is it actually used at all? I can't find any callsites on this.

I guess not. I'll get rid of it.
Comment 4 Build Bot 2017-10-09 11:08:05 PDT 
Comment on attachment 323180 [details]
patch

Attachment 323180 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4801506

New failing tests:
accessibility/mac/css-first-letter-children.html
Comment 5 Build Bot 2017-10-09 11:08:06 PDT 
Created attachment 323189 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 6 Build Bot 2017-10-09 11:13:28 PDT 
Comment on attachment 323180 [details]
patch

Attachment 323180 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4801510

New failing tests:
accessibility/mac/css-first-letter-children.html
Comment 7 Build Bot 2017-10-09 11:13:29 PDT 
Created attachment 323190 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 8 Build Bot 2017-10-09 11:56:49 PDT 
Comment on attachment 323180 [details]
patch

Attachment 323180 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4801817

New failing tests:
accessibility/mac/css-first-letter-children.html
Comment 9 Build Bot 2017-10-09 11:56:50 PDT 
Created attachment 323195 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Antti Koivisto 2017-10-10 02:17:45 PDT 
Created attachment 323292 [details]
patch
Comment 11 Antti Koivisto 2017-10-10 03:39:27 PDT 
https://trac.webkit.org/r223127
Comment 12 Radar WebKit Bug Importer 2017-10-10 03:39:51 PDT 
<rdar://problem/34907673>