RESOLVED FIXED 178084
Add isContinuation bit 
https://bugs.webkit.org/show_bug.cgi?id=178084
Summary Add isContinuation bit
Antti Koivisto
Reported 2017-10-09 09:49:47 PDT
Currently continuations are identified indirectly by comparing renderer pointer with the element renderer pointer. This is bug prone and fails to cover anonymous continuations.
Attachments
patch (11.45 KB, patch)
2017-10-09 09:59 PDT, Antti Koivisto 		zalan: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews103 for mac-elcapitan (1006.87 KB, application/zip)
2017-10-09 11:08 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.08 MB, application/zip)
2017-10-09 11:13 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.87 MB, application/zip)
2017-10-09 11:56 PDT, Build Bot 		no flags
Details
patch (11.91 KB, patch)
2017-10-10 02:17 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-10-09 09:59:24 PDT
Created attachment 323180 [details] patch
zalan
Comment 2 2017-10-09 10:07:30 PDT
Comment on attachment 323180 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=323180&action=review > Source/WebCore/rendering/RenderElement.h:229 > + bool isBlockElementContinuation() const { return isElementContinuation() && !isInline(); } Is it actually used at all? I can't find any callsites on this.
Antti Koivisto
Comment 3 2017-10-09 10:49:39 PDT
> Is it actually used at all? I can't find any callsites on this. I guess not. I'll get rid of it.
Build Bot
Comment 4 2017-10-09 11:08:05 PDT
Comment on attachment 323180 [details] patch Attachment 323180 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4801506 New failing tests: accessibility/mac/css-first-letter-children.html
Build Bot
Comment 5 2017-10-09 11:08:06 PDT
Created attachment 323189 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 6 2017-10-09 11:13:28 PDT
Comment on attachment 323180 [details] patch Attachment 323180 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4801510 New failing tests: accessibility/mac/css-first-letter-children.html
Build Bot
Comment 7 2017-10-09 11:13:29 PDT
Created attachment 323190 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 8 2017-10-09 11:56:49 PDT
Comment on attachment 323180 [details] patch Attachment 323180 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4801817 New failing tests: accessibility/mac/css-first-letter-children.html
Build Bot
Comment 9 2017-10-09 11:56:50 PDT
Created attachment 323195 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Antti Koivisto
Comment 10 2017-10-10 02:17:45 PDT
Created attachment 323292 [details] patch
Antti Koivisto
Comment 11 2017-10-10 03:39:27 PDT
https://trac.webkit.org/r223127
Radar WebKit Bug Importer
Comment 12 2017-10-10 03:39:51 PDT
<rdar://problem/34907673>
Note You need to log in before you can comment on or make changes to this bug.